From 613dad05ce42c0f27040bff7f9d168af05567337 Mon Sep 17 00:00:00 2001 From: SteVen Batten Date: Mon, 3 Jun 2019 17:00:19 -0700 Subject: [PATCH] address feedback --- src/vs/workbench/browser/layout.ts | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/vs/workbench/browser/layout.ts b/src/vs/workbench/browser/layout.ts index 9a811566ba7..fa1ddec1a40 100644 --- a/src/vs/workbench/browser/layout.ts +++ b/src/vs/workbench/browser/layout.ts @@ -63,14 +63,14 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi private readonly _onTitleBarVisibilityChange: Emitter = this._register(new Emitter()); get onTitleBarVisibilityChange(): Event { return this._onTitleBarVisibilityChange.event; } - private readonly _onZenMode: Emitter = this._register(new Emitter()); - get onZenModeChange(): Event { return this._onZenMode.event; } + private readonly _onZenModeChange: Emitter = this._register(new Emitter()); + get onZenModeChange(): Event { return this._onZenModeChange.event; } - private readonly _onFullscreen: Emitter = this._register(new Emitter()); - get onFullscreenChange(): Event { return this._onFullscreen.event; } + private readonly _onFullscreenChange: Emitter = this._register(new Emitter()); + get onFullscreenChange(): Event { return this._onFullscreenChange.event; } - private readonly _onCenteredLayout: Emitter = this._register(new Emitter()); - get onCenteredLayoutChange(): Event { return this._onCenteredLayout.event; } + private readonly _onCenteredLayoutChange: Emitter = this._register(new Emitter()); + get onCenteredLayoutChange(): Event { return this._onCenteredLayoutChange.event; } private readonly _onPanelPositionChange: Emitter = this._register(new Emitter()); get onPanelPositionChange(): Event { return this._onPanelPositionChange.event; } @@ -246,13 +246,13 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi } } - this._onFullscreen.fire(this.state.fullscreen); - // Changing fullscreen state of the window has an impact on custom title bar visibility, so we need to update if (getTitleBarStyle(this.configurationService, this.environmentService) === 'custom') { this._onTitleBarVisibilityChange.fire(); this.layout(); // handle title bar when fullscreen changes } + + this._onFullscreenChange.fire(this.state.fullscreen); } private doUpdateLayoutConfiguration(skipLayout?: boolean): void { @@ -642,7 +642,7 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi } // Event - this._onZenMode.fire(this.state.zenMode.active); + this._onZenModeChange.fire(this.state.zenMode.active); } private setStatusBarHidden(hidden: boolean, skipLayout?: boolean): void { @@ -840,7 +840,7 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi } } - this._onCenteredLayout.fire(this.state.editor.centered); + this._onCenteredLayoutChange.fire(this.state.editor.centered); } resizePart(part: Parts, sizeChange: number): void { @@ -1064,8 +1064,6 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi this.storageService.store(Storage.PANEL_POSITION, positionToString(this.state.panel.position), StorageScope.WORKSPACE); - this._onPanelPositionChange.fire(positionToString(this.state.panel.position)); - // Adjust CSS removeClass(panelPart.getContainer(), oldPositionValue); addClass(panelPart.getContainer(), newPositionValue); @@ -1084,6 +1082,8 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi } else { this.workbenchGrid.layout(); } + + this._onPanelPositionChange.fire(positionToString(this.state.panel.position)); } private savePanelDimension(): void { -- GitLab