From 610487a878317ce49fdfeedbca6b5ae7fb29f171 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Mon, 21 May 2018 13:53:37 -0700 Subject: [PATCH] Still show squiggles if you disable unused variable fade out Fixes #50148 --- .../src/languageProvider.ts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/extensions/typescript-language-features/src/languageProvider.ts b/extensions/typescript-language-features/src/languageProvider.ts index 37037a34d51..7faf5fd5216 100644 --- a/extensions/typescript-language-features/src/languageProvider.ts +++ b/extensions/typescript-language-features/src/languageProvider.ts @@ -3,7 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ -import { languages, workspace, Diagnostic, Disposable, Uri, TextDocument, DocumentFilter } from 'vscode'; +import { languages, workspace, Diagnostic, Disposable, Uri, TextDocument, DocumentFilter, DiagnosticSeverity } from 'vscode'; import { basename } from 'path'; import TypeScriptServiceClient from './typescriptServiceClient'; @@ -273,7 +273,15 @@ export default class LanguageProvider { public diagnosticsReceived(diagnosticsKind: DiagnosticKind, file: Uri, diagnostics: (Diagnostic & { reportUnnecessary: any })[]): void { const config = workspace.getConfiguration(this.id, file); const reportUnnecessary = config.get('showUnused.enabled', true); - this.diagnosticsManager.diagnosticsReceived(diagnosticsKind, file, diagnostics.filter(diag => diag.reportUnnecessary ? reportUnnecessary : true)); + this.diagnosticsManager.diagnosticsReceived(diagnosticsKind, file, diagnostics.filter(diag => { + if (!reportUnnecessary) { + diag.customTags = undefined; + if (diag.reportUnnecessary && diag.severity === DiagnosticSeverity.Hint) { + return false; + } + } + return true; + })); } public configFileDiagnosticsReceived(file: Uri, diagnostics: Diagnostic[]): void { -- GitLab