From 5fb930dc88fde0058e90cb8502b853cdd5e41d28 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Thu, 7 May 2020 17:08:26 +0200 Subject: [PATCH] tests - fix bad regex to unblock build --- src/vs/workbench/contrib/search/common/search.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/contrib/search/common/search.ts b/src/vs/workbench/contrib/search/common/search.ts index 3b738c1cced..b63a4223a13 100644 --- a/src/vs/workbench/contrib/search/common/search.ts +++ b/src/vs/workbench/contrib/search/common/search.ts @@ -103,7 +103,7 @@ export function getOutOfWorkspaceEditorResources(accessor: ServicesAccessor): UR } // Supports patterns of <#|:|(><#|:|,> -const LINE_COLON_PATTERN = /\s?[#:\(](line )?(?\d*)([#:,](?\d*))?\)?\s*$/; +const LINE_COLON_PATTERN = /\s?[#:\(](?:line )?(\d*)(?:[#:,](\d*))?\)?\s*$/; export interface IFilterAndRange { filter: string; @@ -121,7 +121,7 @@ export function extractRangeFromFilter(filter: string, unless?: string[]): IFilt const patternMatch = LINE_COLON_PATTERN.exec(filter); if (patternMatch) { - const startLineNumber = parseInt(patternMatch.groups?.line ?? '', 10); + const startLineNumber = parseInt(patternMatch[1] ?? '', 10); // Line Number if (isNumber(startLineNumber)) { @@ -133,7 +133,7 @@ export function extractRangeFromFilter(filter: string, unless?: string[]): IFilt }; // Column Number - const startColumn = parseInt(patternMatch.groups?.col ?? '', 10); + const startColumn = parseInt(patternMatch[2] ?? '', 10); if (isNumber(startColumn)) { range = { startLineNumber: range.startLineNumber, @@ -145,7 +145,7 @@ export function extractRangeFromFilter(filter: string, unless?: string[]): IFilt } // User has typed "something:" or "something#" without a line number, in this case treat as start of file - else if (patternMatch.groups?.line === '') { + else if (patternMatch[1] === '') { range = { startLineNumber: 1, startColumn: 1, -- GitLab