From 5d064d3008da60c067a5c9cd37edb9429c25e33d Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Mon, 5 Sep 2016 16:00:45 +0200 Subject: [PATCH] fix unreliable test --- .../test/node/configurationService.test.ts | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/vs/workbench/services/configuration/test/node/configurationService.test.ts b/src/vs/workbench/services/configuration/test/node/configurationService.test.ts index 6b386af47d3..42fa2039b6f 100644 --- a/src/vs/workbench/services/configuration/test/node/configurationService.test.ts +++ b/src/vs/workbench/services/configuration/test/node/configurationService.test.ts @@ -188,17 +188,20 @@ suite('WorkspaceConfigurationService - Node', () => { test('global change triggers event', (done: () => void) => { createWorkspace((workspaceDir, globalSettingsFile, cleanUp) => { return createService(workspaceDir, globalSettingsFile).then(service => { - service.onDidUpdateConfiguration(event => { - const config = service.getConfiguration<{ testworkbench: { editor: { icons: boolean } } }>(); - assert.equal(config.testworkbench.editor.icons, true); - assert.equal(event.config.testworkbench.editor.icons, true); + fs.writeFileSync(globalSettingsFile, '{ "testworkbench.editor.icons": false }'); + service.reloadConfiguration().then(() => { + service.onDidUpdateConfiguration(event => { + const config = service.getConfiguration<{ testworkbench: { editor: { icons: boolean } } }>(); + assert.equal(config.testworkbench.editor.icons, true); + assert.equal(event.config.testworkbench.editor.icons, true); - service.dispose(); + service.dispose(); - cleanUp(done); - }); + cleanUp(done); + }); - fs.writeFileSync(globalSettingsFile, '{ "testworkbench.editor.icons": true }'); + fs.writeFileSync(globalSettingsFile, '{ "testworkbench.editor.icons": true }'); + }); }); }); }); -- GitLab