From 59681e54e318e8a8965d49cbec879b562feba071 Mon Sep 17 00:00:00 2001
From: Johannes Rieken <johannes.rieken@gmail.com>
Date: Thu, 7 Mar 2019 15:27:36 +0100
Subject: [PATCH] :lipstick: rename setting to maxVisibileSuggestions, #68557

---
 src/vs/editor/common/config/commonEditorConfig.ts         | 6 +++---
 src/vs/editor/common/config/editorOptions.ts              | 8 ++++----
 src/vs/editor/contrib/suggest/suggestWidget.ts            | 6 +++---
 .../editor/contrib/suggest/test/completionModel.test.ts   | 6 +++---
 src/vs/monaco.d.ts                                        | 2 +-
 5 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/vs/editor/common/config/commonEditorConfig.ts b/src/vs/editor/common/config/commonEditorConfig.ts
index 01c748adc1c..a7aeffe6e58 100644
--- a/src/vs/editor/common/config/commonEditorConfig.ts
+++ b/src/vs/editor/common/config/commonEditorConfig.ts
@@ -684,12 +684,12 @@ const editorConfiguration: IConfigurationNode = {
 			default: EDITOR_DEFAULTS.contribInfo.suggest.showIcons,
 			description: nls.localize('suggest.showIcons', "Controls whether to show or hide icons in suggestions.")
 		},
-		'editor.suggest.maxSuggestionsToShow': {
+		'editor.suggest.maxVisibileSuggestions': {
 			type: 'number',
-			default: EDITOR_DEFAULTS.contribInfo.suggest.maxSuggestionsToShow,
+			default: EDITOR_DEFAULTS.contribInfo.suggest.maxVisibileSuggestions,
 			minimum: 1,
 			maximum: 12,
-			description: nls.localize('suggest.maxSuggestionsToShow', "Controls how many suggestions to show in suggestions.")
+			description: nls.localize('suggest.maxVisibileSuggestions', "Controls how many suggestions IntelliSense will show before showing a scrollbar.")
 		},
 		'editor.selectionHighlight': {
 			'type': 'boolean',
diff --git a/src/vs/editor/common/config/editorOptions.ts b/src/vs/editor/common/config/editorOptions.ts
index f29bfee1365..d123cbcd8d7 100644
--- a/src/vs/editor/common/config/editorOptions.ts
+++ b/src/vs/editor/common/config/editorOptions.ts
@@ -926,7 +926,7 @@ export interface InternalSuggestOptions {
 	readonly localityBonus: boolean;
 	readonly shareSuggestSelections: boolean;
 	readonly showIcons: boolean;
-	readonly maxSuggestionsToShow: number;
+	readonly maxVisibileSuggestions: number;
 }
 
 export interface InternalParameterHintOptions {
@@ -1379,7 +1379,7 @@ export class InternalEditorOptions {
 				&& a.localityBonus === b.localityBonus
 				&& a.shareSuggestSelections === b.shareSuggestSelections
 				&& a.showIcons === b.showIcons
-				&& a.maxSuggestionsToShow === b.maxSuggestionsToShow;
+				&& a.maxVisibileSuggestions === b.maxVisibileSuggestions;
 		}
 	}
 
@@ -1913,7 +1913,7 @@ export class EditorOptionsValidator {
 			localityBonus: _boolean(suggestOpts.localityBonus, defaults.localityBonus),
 			shareSuggestSelections: _boolean(suggestOpts.shareSuggestSelections, defaults.shareSuggestSelections),
 			showIcons: _boolean(suggestOpts.showIcons, defaults.showIcons),
-			maxSuggestionsToShow: _clampedInt(suggestOpts.maxSuggestionsToShow, defaults.maxSuggestionsToShow, 1, 12)
+			maxVisibileSuggestions: _clampedInt(suggestOpts.maxSuggestionsToShow, defaults.maxVisibileSuggestions, 1, 12)
 		};
 	}
 
@@ -2672,7 +2672,7 @@ export const EDITOR_DEFAULTS: IValidatedEditorOptions = {
 			localityBonus: false,
 			shareSuggestSelections: false,
 			showIcons: true,
-			maxSuggestionsToShow: 12
+			maxVisibileSuggestions: 12
 		},
 		selectionHighlight: true,
 		occurrencesHighlight: true,
diff --git a/src/vs/editor/contrib/suggest/suggestWidget.ts b/src/vs/editor/contrib/suggest/suggestWidget.ts
index c334bd799e2..c2d6e178e6a 100644
--- a/src/vs/editor/contrib/suggest/suggestWidget.ts
+++ b/src/vs/editor/contrib/suggest/suggestWidget.ts
@@ -1037,8 +1037,8 @@ export class SuggestWidget implements IContentWidget, IListVirtualDelegate<Compl
 			height = this.unfocusedHeight;
 		} else {
 			const suggestionCount = this.list.contentHeight / this.unfocusedHeight;
-			const maxSuggestionsToShow = this.editor.getConfiguration().contribInfo.suggest.maxSuggestionsToShow;
-			height = Math.min(suggestionCount, maxSuggestionsToShow) * this.unfocusedHeight;
+			const { maxVisibileSuggestions } = this.editor.getConfiguration().contribInfo.suggest;
+			height = Math.min(suggestionCount, maxVisibileSuggestions) * this.unfocusedHeight;
 		}
 
 		this.element.style.lineHeight = `${this.unfocusedHeight}px`;
@@ -1118,7 +1118,7 @@ export class SuggestWidget implements IContentWidget, IListVirtualDelegate<Compl
 	// Heights
 
 	private get maxWidgetHeight(): number {
-		return this.unfocusedHeight * this.editor.getConfiguration().contribInfo.suggest.maxSuggestionsToShow;
+		return this.unfocusedHeight * this.editor.getConfiguration().contribInfo.suggest.maxVisibileSuggestions;
 	}
 
 	private get unfocusedHeight(): number {
diff --git a/src/vs/editor/contrib/suggest/test/completionModel.test.ts b/src/vs/editor/contrib/suggest/test/completionModel.test.ts
index c180a6e8462..92430170908 100644
--- a/src/vs/editor/contrib/suggest/test/completionModel.test.ts
+++ b/src/vs/editor/contrib/suggest/test/completionModel.test.ts
@@ -164,7 +164,7 @@ suite('CompletionModel', function () {
 				localityBonus: false,
 				shareSuggestSelections: false,
 				showIcons: true,
-				maxSuggestionsToShow: 12
+				maxVisibileSuggestions: 12
 			});
 
 		assert.equal(model.items.length, 2);
@@ -191,7 +191,7 @@ suite('CompletionModel', function () {
 				localityBonus: false,
 				shareSuggestSelections: false,
 				showIcons: true,
-				maxSuggestionsToShow: 12
+				maxVisibileSuggestions: 12
 			});
 
 		assert.equal(model.items.length, 2);
@@ -217,7 +217,7 @@ suite('CompletionModel', function () {
 				localityBonus: false,
 				shareSuggestSelections: false,
 				showIcons: true,
-				maxSuggestionsToShow: 12
+				maxVisibileSuggestions: 12
 			});
 
 		assert.equal(model.items.length, 2);
diff --git a/src/vs/monaco.d.ts b/src/vs/monaco.d.ts
index 96cf472ac17..205b649581e 100644
--- a/src/vs/monaco.d.ts
+++ b/src/vs/monaco.d.ts
@@ -3199,7 +3199,7 @@ declare namespace monaco.editor {
 		readonly localityBonus: boolean;
 		readonly shareSuggestSelections: boolean;
 		readonly showIcons: boolean;
-		readonly maxSuggestionsToShow: number;
+		readonly maxVisibileSuggestions: number;
 	}
 
 	export interface InternalParameterHintOptions {
-- 
GitLab