From 592fef42da5d69b86c4641d5e0e5e5da58ac0e95 Mon Sep 17 00:00:00 2001 From: isidor Date: Wed, 22 Apr 2020 17:50:07 +0200 Subject: [PATCH] fix build --- .../browser/parts/notifications/notificationsList.ts | 3 +++ .../browser/parts/notifications/notificationsToasts.ts | 1 - src/vs/workbench/contrib/remote/browser/remote.ts | 4 ++-- src/vs/workbench/contrib/remote/browser/tunnelView.ts | 3 ++- src/vs/workbench/contrib/scm/browser/mainPane.ts | 3 +++ 5 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/browser/parts/notifications/notificationsList.ts b/src/vs/workbench/browser/parts/notifications/notificationsList.ts index 126f1ea74c5..9c6409baaf6 100644 --- a/src/vs/workbench/browser/parts/notifications/notificationsList.ts +++ b/src/vs/workbench/browser/parts/notifications/notificationsList.ts @@ -100,6 +100,9 @@ export class NotificationsList extends Themable { }, getWidgetAriaLabel(): string { return localize('notificationsList', "Notifications List"); + }, + getWidgetRole(): string { + return 'dialog'; // https://github.com/microsoft/vscode/issues/82728 } } } diff --git a/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts b/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts index b2ab6c301ed..9953c034128 100644 --- a/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts +++ b/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts @@ -169,7 +169,6 @@ export class NotificationsToasts extends Themable implements INotificationsToast // Create toast with item and show const notificationList = this.instantiationService.createInstance(NotificationsList, notificationToast, { - ariaRole: 'dialog', // https://github.com/microsoft/vscode/issues/82728 verticalScrollMode: ScrollbarVisibility.Hidden }); itemDisposables.add(notificationList); diff --git a/src/vs/workbench/contrib/remote/browser/remote.ts b/src/vs/workbench/contrib/remote/browser/remote.ts index 5d4bb056f39..02c4048c777 100644 --- a/src/vs/workbench/contrib/remote/browser/remote.ts +++ b/src/vs/workbench/contrib/remote/browser/remote.ts @@ -405,7 +405,8 @@ class HelpPanel extends ViewPane { accessibilityProvider: { getAriaLabel: (item: HelpItemBase) => { return item.label; - } + }, + getWidgetAriaLabel: () => nls.localize('remotehelp', "Remote Help") } } ); @@ -817,4 +818,3 @@ class RemoteAgentConnectionStatusListener implements IWorkbenchContribution { const workbenchContributionsRegistry = Registry.as(WorkbenchExtensions.Workbench); workbenchContributionsRegistry.registerWorkbenchContribution(RemoteAgentConnectionStatusListener, LifecyclePhase.Eventually); workbenchContributionsRegistry.registerWorkbenchContribution(RemoteWindowActiveIndicator, LifecyclePhase.Starting); - diff --git a/src/vs/workbench/contrib/remote/browser/tunnelView.ts b/src/vs/workbench/contrib/remote/browser/tunnelView.ts index 1adbe775b59..3841724de83 100644 --- a/src/vs/workbench/contrib/remote/browser/tunnelView.ts +++ b/src/vs/workbench/contrib/remote/browser/tunnelView.ts @@ -519,7 +519,8 @@ export class TunnelPanel extends ViewPane { } else { return item.label; } - } + }, + getWidgetAriaLabel: () => nls.localize('tunnelView', "Tunnel View") } } ); diff --git a/src/vs/workbench/contrib/scm/browser/mainPane.ts b/src/vs/workbench/contrib/scm/browser/mainPane.ts index 2a9bd6e9f23..1a99ac99db5 100644 --- a/src/vs/workbench/contrib/scm/browser/mainPane.ts +++ b/src/vs/workbench/contrib/scm/browser/mainPane.ts @@ -212,6 +212,9 @@ export class MainPane extends ViewPane { accessibilityProvider: { getAriaLabel(r: ISCMRepository) { return r.provider.label; + }, + getWidgetAriaLabel() { + return MainPane.TITLE; } } }) as WorkbenchList; -- GitLab