From 56fb08bd529544ac1eb9d89abd7a4af53bf508de Mon Sep 17 00:00:00 2001 From: Jackson Kearl Date: Wed, 27 Jun 2018 16:58:11 -0700 Subject: [PATCH] Fix bug causing recommendation ignore message not going away (#53189) --- .../parts/extensions/electron-browser/extensionEditor.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts index 51fe81f799b..f3a1da645e0 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts @@ -401,9 +401,9 @@ export class ExtensionEditor extends BaseEditor { this.extensionTipsService.onRecommendationChange(change => { if (change.extensionId.toLowerCase() === extension.id.toLowerCase()) { if (change.isRecommended) { + removeClass(this.header, 'recommendation-ignored'); const extRecommendations = this.extensionTipsService.getAllRecommendationsWithReason(); if (extRecommendations[extension.id.toLowerCase()]) { - removeClass(this.header, 'recommendation-ignored'); addClass(this.header, 'recommended'); this.recommendationText.textContent = extRecommendations[extension.id.toLowerCase()].reasonText; } -- GitLab