From 56dad588fe1f6d4c8284603097c662f36219d0e2 Mon Sep 17 00:00:00 2001 From: isidor Date: Mon, 23 Jan 2017 15:41:48 +0100 Subject: [PATCH] Enable to add a launch configuration snippet when there is no launch.json fixes #18853 --- src/vs/base/browser/ui/selectBox/selectBox.ts | 9 ------- .../parts/debug/browser/debugActionItems.ts | 25 ++++++------------- 2 files changed, 7 insertions(+), 27 deletions(-) diff --git a/src/vs/base/browser/ui/selectBox/selectBox.ts b/src/vs/base/browser/ui/selectBox/selectBox.ts index 72c68596089..274f2b2b487 100644 --- a/src/vs/base/browser/ui/selectBox/selectBox.ts +++ b/src/vs/base/browser/ui/selectBox/selectBox.ts @@ -70,15 +70,6 @@ export class SelectBox extends Widget { } } - public set enabled(value: boolean) { - dom.toggleClass(this.container, 'disabled', !value); - this.selectElement.disabled = !value; - } - - public get enabled(): boolean { - return !this.selectElement.disabled; - } - public blur(): void { if (this.selectElement) { this.selectElement.blur(); diff --git a/src/vs/workbench/parts/debug/browser/debugActionItems.ts b/src/vs/workbench/parts/debug/browser/debugActionItems.ts index 5fee998bf96..6dceacd9ff6 100644 --- a/src/vs/workbench/parts/debug/browser/debugActionItems.ts +++ b/src/vs/workbench/parts/debug/browser/debugActionItems.ts @@ -77,9 +77,7 @@ export class StartDebugActionItem extends EventEmitter implements IActionItem { })); this.toDispose.push(dom.addDisposableListener(this.start, dom.EventType.MOUSE_DOWN, () => { - if (this.selectBox.enabled) { - dom.addClass(this.start, 'active'); - } + dom.addClass(this.start, 'active'); })); this.toDispose.push(dom.addDisposableListener(this.start, dom.EventType.MOUSE_UP, () => { dom.removeClass(this.start, 'active'); @@ -104,7 +102,7 @@ export class StartDebugActionItem extends EventEmitter implements IActionItem { } public isEnabled(): boolean { - return this.selectBox.enabled; + return true; } public focus(): void { @@ -119,24 +117,15 @@ export class StartDebugActionItem extends EventEmitter implements IActionItem { this.toDispose = lifecycle.dispose(this.toDispose); } - private setEnabled(enabled: boolean): void { - this.selectBox.enabled = enabled; - if (!enabled) { - this.selectBox.setOptions([nls.localize('noConfigurations', "No Configurations")], 0); - } - } - private updateOptions(): void { const options = this.debugService.getConfigurationManager().getConfigurationNames(); if (options.length === 0) { - this.setEnabled(false); - } else { - this.setEnabled(true); - const selected = options.indexOf(this.debugService.getViewModel().selectedConfigurationName); - options.push(StartDebugActionItem.SEPARATOR); - options.push(StartDebugActionItem.ADD_CONFIGURATION); - this.selectBox.setOptions(options, selected, options.length - 2); + options.push(nls.localize('noConfigurations', "No Configurations")); } + const selected = options.indexOf(this.debugService.getViewModel().selectedConfigurationName); + options.push(StartDebugActionItem.SEPARATOR); + options.push(StartDebugActionItem.ADD_CONFIGURATION); + this.selectBox.setOptions(options, selected, options.length - 2); } } -- GitLab