From 564b7120ab051f61849ad00e77be502fd55bffb4 Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Thu, 21 Feb 2019 11:32:32 +0100 Subject: [PATCH] clean up --- src/vs/workbench/api/node/extHostDebugService.ts | 2 +- src/vs/workbench/api/node/extHostTask.ts | 4 ++-- src/vs/workbench/api/node/extHostWorkspace.ts | 11 ++--------- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/src/vs/workbench/api/node/extHostDebugService.ts b/src/vs/workbench/api/node/extHostDebugService.ts index 1b44f2898d4..f4ef3fc28b6 100644 --- a/src/vs/workbench/api/node/extHostDebugService.ts +++ b/src/vs/workbench/api/node/extHostDebugService.ts @@ -794,7 +794,7 @@ export class ExtHostDebugService implements ExtHostDebugServiceShape { private async getFolder(_folderUri: UriComponents | undefined): Promise { if (_folderUri) { const folderURI = URI.revive(_folderUri); - return await this._workspaceService.resolveWorkspaceFolder2(folderURI); + return await this._workspaceService.resolveWorkspaceFolder(folderURI); } return undefined; } diff --git a/src/vs/workbench/api/node/extHostTask.ts b/src/vs/workbench/api/node/extHostTask.ts index cf5f6b0dcfd..eeed4f06b6e 100644 --- a/src/vs/workbench/api/node/extHostTask.ts +++ b/src/vs/workbench/api/node/extHostTask.ts @@ -239,7 +239,7 @@ namespace TaskDTO { if (typeof value.source.scope === 'number') { scope = value.source.scope; } else { - scope = await workspace.resolveWorkspaceFolder2(URI.revive(value.source.scope)); + scope = await workspace.resolveWorkspaceFolder(URI.revive(value.source.scope)); } } else { scope = types.TaskScope.Workspace; @@ -477,7 +477,7 @@ export class ExtHostTask implements ExtHostTaskShape { process: undefined as string, variables: Object.create(null) }; - let workspaceFolder = await this._workspaceProvider.resolveWorkspaceFolder2(uri); + let workspaceFolder = await this._workspaceProvider.resolveWorkspaceFolder(uri); const workspaceFolders = await this._workspaceProvider.getWorkspaceFolders2(); let resolver = new ExtHostVariableResolverService(workspaceFolders, this._editorService, configProvider); let ws: IWorkspaceFolder = { diff --git a/src/vs/workbench/api/node/extHostWorkspace.ts b/src/vs/workbench/api/node/extHostWorkspace.ts index 6de98c9c63c..42d5024c469 100644 --- a/src/vs/workbench/api/node/extHostWorkspace.ts +++ b/src/vs/workbench/api/node/extHostWorkspace.ts @@ -28,7 +28,7 @@ import { Barrier } from 'vs/base/common/async'; export interface IExtHostWorkspaceProvider { getWorkspaceFolder2(uri: vscode.Uri, resolveParent?: boolean): Promise; - resolveWorkspaceFolder2(uri: vscode.Uri): Promise; + resolveWorkspaceFolder(uri: vscode.Uri): Promise; getWorkspaceFolders2(): Promise; resolveProxy(url: string): Promise; } @@ -296,14 +296,7 @@ export class ExtHostWorkspace implements ExtHostWorkspaceShape, IExtHostWorkspac return this._actualWorkspace.getWorkspaceFolder(uri, resolveParent); } - resolveWorkspaceFolder(uri: vscode.Uri): vscode.WorkspaceFolder | undefined { - if (!this._actualWorkspace) { - return undefined; - } - return this._actualWorkspace.resolveWorkspaceFolder(uri); - } - - async resolveWorkspaceFolder2(uri: vscode.Uri): Promise { + async resolveWorkspaceFolder(uri: vscode.Uri): Promise { await this._barrier.wait(); if (!this._actualWorkspace) { return undefined; -- GitLab