From 5562872fead3a01ddcb7f593e375b94ddbcaaf1b Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Thu, 6 Dec 2018 20:09:23 -0800 Subject: [PATCH] Remove workaround for ts infer type suggestions showing up with no quick fix This should not be needed now that we are shipping TS 3.2.2 --- .../src/typeScriptServiceClientHost.ts | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/extensions/typescript-language-features/src/typeScriptServiceClientHost.ts b/extensions/typescript-language-features/src/typeScriptServiceClientHost.ts index 393b9ad14de..9c76d5e50ab 100644 --- a/extensions/typescript-language-features/src/typeScriptServiceClientHost.ts +++ b/extensions/typescript-language-features/src/typeScriptServiceClientHost.ts @@ -266,17 +266,7 @@ export default class TypeScriptServiceClientHost extends Disposable { diagnostics: Proto.Diagnostic[], source: string ): (vscode.Diagnostic & { reportUnnecessary: any })[] { - return diagnostics - .filter(tsDiag => { - // See https://github.com/Microsoft/TypeScript/issues/28702 - // The infer type suggestions are being returned even when no code action is available. - // Hide these on broken versions of TS because showing them currently is very confusing. - if (tsDiag.code === 7044) { - return !(this.client.apiVersion.gte(API.v320) && this.client.apiVersion.lt(API.v330)); - } - return true; - }) - .map(tsDiag => this.tsDiagnosticToVsDiagnostic(tsDiag, source)); + return diagnostics.map(tsDiag => this.tsDiagnosticToVsDiagnostic(tsDiag, source)); } private tsDiagnosticToVsDiagnostic(diagnostic: Proto.Diagnostic, source: string): vscode.Diagnostic & { reportUnnecessary: any } { -- GitLab