From 54f7922ad10841783145fcfe4e8882d6526f5b56 Mon Sep 17 00:00:00 2001 From: Ramya Achutha Rao Date: Mon, 19 Nov 2018 22:53:05 -0800 Subject: [PATCH] Use reloadAction.onDidChange to set the text --- .../extensions/electron-browser/extensionEditor.ts | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts index c9d4dabd9d8..8b8f3737801 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts @@ -48,7 +48,6 @@ import { ExtensionsTree, IExtensionData } from 'vs/workbench/parts/extensions/br import { ShowCurrentReleaseNotesAction } from 'vs/workbench/parts/update/electron-browser/update'; import { KeybindingParser } from 'vs/base/common/keybindingParser'; import { IStorageService } from 'vs/platform/storage/common/storage'; -import { areSameExtensions } from 'vs/platform/extensionManagement/common/extensionManagementUtil'; function renderBody(body: string): string { const styleSheetPath = require.toUrl('./media/markdown.css').replace('file://', 'vscode-core-resource://'); @@ -403,12 +402,6 @@ export class ExtensionEditor extends BaseEditor { } private setSubText(extension: IExtension, reloadAction: ReloadAction) { - if (reloadAction.enabled) { - this.subtext.textContent = reloadAction.tooltip; - show(this.subtextContainer); - return; - } - hide(this.subtextContainer); const ignoreAction = this.instantiationService.createInstance(IgnoreExtensionRecommendationAction); @@ -453,8 +446,8 @@ export class ExtensionEditor extends BaseEditor { } }); - this.extensionsWorkbenchService.onChange(e => { - if (areSameExtensions(e, extension) && reloadAction.enabled) { + reloadAction.onDidChange(e => { + if (e.tooltip) { this.subtext.textContent = reloadAction.tooltip; show(this.subtextContainer); ignoreAction.enabled = false; -- GitLab