From 5253f9b2d2899631e27e7503d71dce30ff13b1b6 Mon Sep 17 00:00:00 2001 From: Joao Moreno Date: Tue, 8 Dec 2015 15:51:56 +0100 Subject: [PATCH] suggest: more telemetry fixes --- .../editor/contrib/suggest/browser/suggestWidget.ts | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/vs/editor/contrib/suggest/browser/suggestWidget.ts b/src/vs/editor/contrib/suggest/browser/suggestWidget.ts index c299b7a0748..5778c74b9b3 100644 --- a/src/vs/editor/contrib/suggest/browser/suggestWidget.ts +++ b/src/vs/editor/contrib/suggest/browser/suggestWidget.ts @@ -460,13 +460,18 @@ export class SuggestWidget implements EditorBrowser.IContentWidget, IDisposable if (e.selection && e.selection.length > 0) { var element = e.selection[0]; if (!element.hasOwnProperty('suggestions') && !(element instanceof MessageRoot) && !(element instanceof Message)) { + const item: CompletionItem = element; + const navigator = this.tree.getNavigator(); - // TODO@joao bring back - // this.telemetryData.selectedIndex = ( this.tree.getInput()).completionItems.indexOf(element); + this.telemetryData.selectedIndex = 0; this.telemetryData.wasCancelled = false; + + while (navigator.next() !== item) { + this.telemetryData.selectedIndex++; + } + this.submitTelemetryData(); - const item: CompletionItem = element; const container = item.container; const overwriteBefore = (typeof container.overwriteBefore === 'undefined') ? container.currentWord.length : container.overwriteBefore; const overwriteAfter = (typeof container.overwriteAfter === 'undefined') ? 0 : Math.max(0, container.overwriteAfter); @@ -586,7 +591,7 @@ export class SuggestWidget implements EditorBrowser.IContentWidget, IDisposable } dom.removeClass(this.element, 'empty'); - + this.telemetryData = this.telemetryData || {}; this.tree.setInput(model).done(() => { -- GitLab