From 4f0b658c244991256c84c13e6c1c9d35896cc815 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Wed, 15 May 2019 10:51:19 -0700 Subject: [PATCH] Make simple file dialog setting a real setting Fixes #73783 --- src/vs/workbench/browser/workbench.contribution.ts | 5 +++++ .../workbench/services/dialogs/browser/fileDialogService.ts | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/browser/workbench.contribution.ts b/src/vs/workbench/browser/workbench.contribution.ts index 696f351bc09..e9cf5a91312 100644 --- a/src/vs/workbench/browser/workbench.contribution.ts +++ b/src/vs/workbench/browser/workbench.contribution.ts @@ -239,6 +239,11 @@ import { isMacintosh } from 'vs/base/common/platform'; 'description': nls.localize('workbench.useExperimentalGridLayout', "Enables the grid layout for the workbench. This setting may enable additional layout options for workbench components."), 'default': false, 'scope': ConfigurationScope.APPLICATION + }, + 'workbench.simpleFileDialog.enable': { + 'type': 'boolean', + 'description': nls.localize('workbench.simpleFileDialog.enable', "Enables the simple file dialog. The simple file dialog replaces the system file dialog when enabled."), + 'default': false, } } }); diff --git a/src/vs/workbench/services/dialogs/browser/fileDialogService.ts b/src/vs/workbench/services/dialogs/browser/fileDialogService.ts index 4d50a0b8ff0..b54e64c6e21 100644 --- a/src/vs/workbench/services/dialogs/browser/fileDialogService.ts +++ b/src/vs/workbench/services/dialogs/browser/fileDialogService.ts @@ -85,8 +85,8 @@ export class FileDialogService implements IFileDialogService { } private shouldUseSimplified(schema: string): boolean { - const setting = this.configurationService.getValue('workbench.dialogs.useSimplified'); - return (schema !== Schemas.file) || ((setting === 'true') || (setting === true)); + const setting = this.configurationService.getValue('workbench.simpleFileDialog.enable'); + return (schema !== Schemas.file) || (setting === true); } private ensureFileSchema(schema: string): string[] { -- GitLab