From 4ceb27c9aea8fd6ec959d460350c7bb9b14053c6 Mon Sep 17 00:00:00 2001
From: Miguel Solorio <miguel.solorio@microsoft.com>
Date: Tue, 6 Aug 2019 09:56:40 -0700
Subject: [PATCH] Update settings editor list to 24px and add padding for add
 new

---
 .../preferences/browser/media/settingsWidgets.css      | 10 +++++-----
 .../contrib/preferences/browser/settingsWidgets.ts     |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/vs/workbench/contrib/preferences/browser/media/settingsWidgets.css b/src/vs/workbench/contrib/preferences/browser/media/settingsWidgets.css
index 060fc54921c..ff5f813a4fc 100644
--- a/src/vs/workbench/contrib/preferences/browser/media/settingsWidgets.css
+++ b/src/vs/workbench/contrib/preferences/browser/media/settingsWidgets.css
@@ -29,7 +29,7 @@
 .settings-editor > .settings-body > .settings-tree-container .setting-item.setting-item-list .setting-list-value,
 .settings-editor > .settings-body > .settings-tree-container .setting-item.setting-item-list .setting-list-sibling {
 	display: inline-block;
-	line-height: 22px;
+	line-height: 24px;
 }
 
 /* Use monospace to display glob patterns in exclude widget */
@@ -49,12 +49,11 @@
 	display: none;
 	position: absolute;
 	right: 0px;
-	margin-top: 1px;
 }
 
 .settings-editor > .settings-body > .settings-tree-container .setting-item.setting-item-list .setting-list-row {
 	position: relative;
-	max-height: 22px;
+	max-height: 24px;
 }
 
 .settings-editor > .settings-body > .settings-tree-container .setting-item.setting-item-list .setting-list-row:focus {
@@ -68,7 +67,7 @@
 
 .settings-editor > .settings-body > .settings-tree-container .setting-item.setting-item-list .setting-list-row .monaco-action-bar .action-label {
 	width: 16px;
-	height: 16px;
+	height: 20px;
 	padding: 2px;
 	margin-right: 2px;
 }
@@ -103,6 +102,7 @@
 }
 
 .settings-editor > .settings-body > .settings-tree-container .setting-item.setting-item-list .monaco-text-button.setting-list-addButton {
+	margin-top: 4px;
 	margin-right: 10px;
 }
 
@@ -112,7 +112,7 @@
 
 .settings-editor > .settings-body > .settings-tree-container .setting-item.setting-item-list .setting-list-valueInput,
 .settings-editor > .settings-body > .settings-tree-container .setting-item.setting-item-list .setting-list-siblingInput {
-	height: 22px;
+	height: 24px;
 	max-width: 320px;
 	flex: 1;
 	margin-right: 10px;
diff --git a/src/vs/workbench/contrib/preferences/browser/settingsWidgets.ts b/src/vs/workbench/contrib/preferences/browser/settingsWidgets.ts
index ad1b781ae28..cb7d13e51e5 100644
--- a/src/vs/workbench/contrib/preferences/browser/settingsWidgets.ts
+++ b/src/vs/workbench/contrib/preferences/browser/settingsWidgets.ts
@@ -346,7 +346,7 @@ export class ListSettingWidget extends Disposable {
 			.map((item, i) => this.renderItem(item, i, focused))
 			.forEach(itemElement => this.listElement.appendChild(itemElement));
 
-		const listHeight = 22 * this.model.items.length;
+		const listHeight = 24 * this.model.items.length;
 		this.listElement.style.height = listHeight + 'px';
 	}
 
-- 
GitLab