From 4c7fed552323a91c02f0c6a1a4c498f27db74fc8 Mon Sep 17 00:00:00 2001
From: Martin Aeschlimann <martinae@microsoft.com>
Date: Thu, 25 Apr 2019 09:33:09 +0200
Subject: [PATCH] bug with preventing saving an already open workspsace

---
 .../workspace/electron-browser/workspaceEditingService.ts     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/vs/workbench/services/workspace/electron-browser/workspaceEditingService.ts b/src/vs/workbench/services/workspace/electron-browser/workspaceEditingService.ts
index 95f23606581..b09b8d1d520 100644
--- a/src/vs/workbench/services/workspace/electron-browser/workspaceEditingService.ts
+++ b/src/vs/workbench/services/workspace/electron-browser/workspaceEditingService.ts
@@ -244,7 +244,7 @@ export class WorkspaceEditingService implements IWorkspaceEditingService {
 	}
 
 	async createAndEnterWorkspace(folders: IWorkspaceFolderCreationData[], path?: URI): Promise<void> {
-		if (path && !this.isValidTargetWorkspacePath(path)) {
+		if (path && !await this.isValidTargetWorkspacePath(path)) {
 			return Promise.reject(null);
 		}
 		const remoteAuthority = this.environmentService.configuration.remoteAuthority;
@@ -258,7 +258,7 @@ export class WorkspaceEditingService implements IWorkspaceEditingService {
 	}
 
 	async saveAndEnterWorkspace(path: URI): Promise<void> {
-		if (!this.isValidTargetWorkspacePath(path)) {
+		if (!await this.isValidTargetWorkspacePath(path)) {
 			return Promise.reject(null);
 		}
 		const workspaceIdentifier = this.getCurrentWorkspaceIdentifier();
-- 
GitLab