From 470bc088b34e7ba47c26a54634539b822979adee Mon Sep 17 00:00:00 2001 From: Rob Lourens Date: Thu, 23 Apr 2020 09:57:23 -0500 Subject: [PATCH] Fix errors thrown when opening search results in non-code-editors --- src/vs/workbench/contrib/search/browser/searchView.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/search/browser/searchView.ts b/src/vs/workbench/contrib/search/browser/searchView.ts index e8b045a8586..f80381fac40 100644 --- a/src/vs/workbench/contrib/search/browser/searchView.ts +++ b/src/vs/workbench/contrib/search/browser/searchView.ts @@ -1657,7 +1657,7 @@ export class SearchView extends ViewPane { revealIfVisible: true } }, sideBySide ? SIDE_GROUP : ACTIVE_GROUP).then(editor => { - if (editor && element instanceof Match && preserveFocus) { + if (element instanceof Match && preserveFocus && isCodeEditor(editor)) { this.viewModel.searchResult.rangeHighlightDecorations.highlightRange( (editor.getControl()).getModel()!, element.range() -- GitLab