From 451372e82b5d5e988db0c52df89de5106c24827b Mon Sep 17 00:00:00 2001 From: Ramya Achutha Rao Date: Tue, 27 Mar 2018 14:59:06 -0700 Subject: [PATCH] Add old properties back until we retire them post nova --- .../extensionManagement/common/extensionManagementUtil.ts | 6 ++++++ src/vs/workbench/api/node/extHostExtensionService.ts | 2 ++ .../themes/electron-browser/workbenchThemeService.ts | 2 ++ 3 files changed, 10 insertions(+) diff --git a/src/vs/platform/extensionManagement/common/extensionManagementUtil.ts b/src/vs/platform/extensionManagement/common/extensionManagementUtil.ts index 80d5857e87e..54fcf01e4d9 100644 --- a/src/vs/platform/extensionManagement/common/extensionManagementUtil.ts +++ b/src/vs/platform/extensionManagement/common/extensionManagementUtil.ts @@ -79,6 +79,9 @@ export function getLocalExtensionTelemetryData(extension: ILocalExtension): any "id" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "name": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "galleryId": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, + "publisherId": { "classification": "PublicPersonalData", "purpose": "FeatureInsight" }, + "publisherName": { "classification": "PublicPersonalData", "purpose": "FeatureInsight" }, + "publisherDisplayName": { "classification": "PublicPersonalData", "purpose": "FeatureInsight" }, "galleryPublisherId": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }, "galleryPublisherName": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }, "galleryPublisherDisplayName": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }, @@ -93,6 +96,9 @@ export function getGalleryExtensionTelemetryData(extension: IGalleryExtension): id: extension.identifier.id, name: extension.name, galleryId: extension.identifier.uuid, + publisherId: extension.publisherId, + publisherName: extension.publisher, + publisherDisplayName: extension.publisherDisplayName, galleryPublisherId: extension.publisherId, galleryPublisherName: extension.publisher, galleryPublisherDisplayName: extension.publisherDisplayName, diff --git a/src/vs/workbench/api/node/extHostExtensionService.ts b/src/vs/workbench/api/node/extHostExtensionService.ts index 7b05b265c8d..949c69abdca 100644 --- a/src/vs/workbench/api/node/extHostExtensionService.ts +++ b/src/vs/workbench/api/node/extHostExtensionService.ts @@ -423,6 +423,7 @@ function getTelemetryActivationEvent(extensionDescription: IExtensionDescription "TelemetryActivationEvent" : { "id": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }, "name": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }, + "publisherDisplayName": { "classification": "PublicPersonalData", "purpose": "FeatureInsight" }, "galleryPublisherDisplayName": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }, "activationEvents": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "isBuiltin": { "classification": "SystemMetaData", "purpose": "FeatureInsight" } @@ -431,6 +432,7 @@ function getTelemetryActivationEvent(extensionDescription: IExtensionDescription let event = { id: extensionDescription.id, name: extensionDescription.name, + publisherDisplayName: extensionDescription.publisher, galleryPublisherDisplayName: extensionDescription.publisher, activationEvents: extensionDescription.activationEvents ? extensionDescription.activationEvents.join(',') : null, isBuiltin: extensionDescription.isBuiltin diff --git a/src/vs/workbench/services/themes/electron-browser/workbenchThemeService.ts b/src/vs/workbench/services/themes/electron-browser/workbenchThemeService.ts index 60ec28900df..9c91aa72e6f 100644 --- a/src/vs/workbench/services/themes/electron-browser/workbenchThemeService.ts +++ b/src/vs/workbench/services/themes/electron-browser/workbenchThemeService.ts @@ -362,6 +362,7 @@ export class WorkbenchThemeService implements IWorkbenchThemeService { "id" : { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }, "name": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }, "isBuiltin": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }, + "publisherDisplayName": { "classification": "PublicPersonalData", "purpose": "FeatureInsight" }, "galleryPublisherDisplayName": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }, "themeId": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" } } @@ -370,6 +371,7 @@ export class WorkbenchThemeService implements IWorkbenchThemeService { id: themeData.extensionId, name: themeData.extensionName, isBuiltin: themeData.extensionIsBuiltin, + publisherDisplayName: themeData.extensionPublisher, galleryPublisherDisplayName: themeData.extensionPublisher, themeId: themeId }); -- GitLab