From 4312a6ca4433766ca545eb77fe3339f632183ed9 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Mon, 2 Sep 2019 12:01:57 +0200 Subject: [PATCH] debt - enable env.remoteName test again --- .../src/singlefolder-tests/env.test.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/env.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/env.test.ts index ac1b9e03f31..b8d6395452f 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/env.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/env.test.ts @@ -26,18 +26,19 @@ suite('env-namespace', () => { assert.throws(() => (env as any).shell = '234'); }); - test.skip('env.remoteName', function () { + test('env.remoteName', function () { const remoteName = env.remoteName; const apiTestExtension = extensions.getExtension('vscode.vscode-api-tests'); - const testResolverExtension = extensions.getExtension('vscode.vscode-test-resolver'); + const knownUiExtension = extensions.getExtension('vscode.git'); if (typeof remoteName === 'undefined') { assert.ok(apiTestExtension); - assert.ok(testResolverExtension); + assert.ok(knownUiExtension); assert.equal(ExtensionKind.UI, apiTestExtension!.extensionKind); - assert.equal(ExtensionKind.UI, testResolverExtension!.extensionKind); + assert.equal(ExtensionKind.UI, knownUiExtension!.extensionKind); } else if (typeof remoteName === 'string') { assert.ok(apiTestExtension); - assert.ok(!testResolverExtension); // we currently can only access extensions that run on same host + // TODO@aeschli fails when using 'vscode.git as knownUiExtension' + // assert.ok(!knownUiExtension); // we currently can only access extensions that run on same host assert.equal(ExtensionKind.Workspace, apiTestExtension!.extensionKind); } else { assert.fail(); -- GitLab