Settings editor - fix editing settings during search

src/vs/workbench/parts/preferences/browser/settingsEditor2.ts

@@ -565,6 +565,10 @@ export class SettingsEditor2 extends BaseEditor {
 
 		resolvedSettingsRoot.children.push(resolveExtensionsSettings(dividedGroups.extension || []));
 
+		if (this.searchResultModel) {
+			this.searchResultModel.updateChildren();
+		}
+
 		if (this.settingsTreeModel) {
 			this.settingsTreeModel.update(resolvedSettingsRoot);
 		} else {

src/vs/workbench/parts/preferences/browser/settingsTree.ts

@@ -907,10 +907,12 @@ export class SearchResultModel {
 		}
 
 		this.rawSearchResults[type] = result;
+		this.updateChildren();
+	}
 
-		// Recompute children
+	updateChildren(): void {
 		this.children = this.getFlatSettings()
-			.map(s => createSettingsTreeSettingElement(s, result, this._viewState.settingsTarget, this._configurationService));
+			.map(s => createSettingsTreeSettingElement(s, this, this._viewState.settingsTarget, this._configurationService));
 	}
 
 	private getFlatSettings(): ISetting[] {