#16580 Provide option to not to notify error by default. This is needed for extension API

src/vs/workbench/api/electron-browser/mainThreadConfiguration.ts

@@ -35,10 +35,10 @@ export class MainThreadConfiguration extends MainThreadConfigurationShape {
 	}
 
 	$updateConfigurationOption(target: ConfigurationTarget, key: string, value: any): TPromise<void> {
-		return this._configurationEditingService.writeConfiguration(target, { key, value });
+		return this._configurationEditingService.writeConfiguration(target, { key, value }, { donotNotifyError: true });
 	}
 
 	$removeConfigurationOption(target: ConfigurationTarget, key: string): TPromise<void> {
-		return this._configurationEditingService.writeConfiguration(target, { key, value: undefined });
+		return this._configurationEditingService.writeConfiguration(target, { key, value: undefined }, { donotNotifyError: true });
 	}
 }

src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts

@@ -24,7 +24,7 @@ import { IContextMenuService, ContextSubMenu } from 'vs/platform/contextview/bro
 import { SettingsGroupTitleWidget, EditPreferenceWidget } from 'vs/workbench/parts/preferences/browser/preferencesWidgets';
 import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
 import { RangeHighlightDecorations } from 'vs/workbench/common/editor/rangeDecorations';
-import { IConfigurationEditingService } from 'vs/workbench/services/configuration/common/configurationEditing';
+import { IConfigurationEditingService, IConfigurationEditingError, ConfigurationEditingErrorCode, ConfigurationTarget } from 'vs/workbench/services/configuration/common/configurationEditing';
 import { ITextFileService } from 'vs/workbench/services/textfile/common/textfiles';
 import { overrideIdentifierFromKey } from 'vs/platform/configuration/common/model';
 import { IMarkerService, IMarkerData } from 'vs/platform/markers/common/markers';
@@ -100,8 +100,19 @@ export class UserSettingsRenderer extends Disposable implements IPreferencesRend
 	public updatePreference(key: string, value: any, source: ISetting): void {
 		this.telemetryService.publicLog('defaultSettingsActions.copySetting', { userConfigurationKeys: [key] });
 		const overrideIdentifier = source.overrideOf ? overrideIdentifierFromKey(source.overrideOf.key) : null;
-		this.configurationEditingService.writeConfiguration(this.preferencesModel.configurationTarget, { key, value, overrideIdentifier }, !this.textFileService.isDirty(this.preferencesModel.uri))
-			.then(() => this.onSettingUpdated(source));
+		this.configurationEditingService.writeConfiguration(this.preferencesModel.configurationTarget, { key, value, overrideIdentifier }, { donotSave: this.textFileService.isDirty(this.preferencesModel.uri), donotNotifyError: true })
+			.then(() => this.onSettingUpdated(source), error => {
+				this.messageService.show(Severity.Error, this.toErrorMessage(error, this.preferencesModel.configurationTarget));
+			});
+	}
+
+	private toErrorMessage(error: IConfigurationEditingError, target: ConfigurationTarget): string {
+		switch (error.code) {
+			case ConfigurationEditingErrorCode.ERROR_INVALID_CONFIGURATION: {
+				return nls.localize('errorInvalidConfiguration', "Unable to write into settings. Correct errors/warnings in the file and try again.");
+			};
+		}
+		return error.message;
 	}
 
 	private onModelChanged(): void {

src/vs/workbench/parts/preferences/browser/preferencesService.ts

@@ -325,7 +325,7 @@ export class PreferencesService extends Disposable implements IPreferencesServic
 					}
 					return { lineNumber: setting.valueRange.startLineNumber, column: setting.valueRange.startColumn + 1 };
 				}
-				return this.configurationEditingService.writeConfiguration(ConfigurationTarget.USER, { key: languageKey, value: {} }, false)
+				return this.configurationEditingService.writeConfiguration(ConfigurationTarget.USER, { key: languageKey, value: {} }, { donotSave: true })
 					.then(() => {
 						setting = settingsModel.getPreference(languageKey);
 						let content = eol + this.spaces(2, configuration) + eol + this.spaces(1, configuration);

src/vs/workbench/services/configuration/common/configurationEditing.ts

@@ -61,6 +61,17 @@ export interface IConfigurationValue {
 	overrideIdentifier?: string;
 }
 
+export interface IConfigurationEditingOptions {
+	/**
+	 * If `true`, do not saves the configuration. Default is `false`.
+	 */
+	donotSave?: boolean;
+	/**
+	 * If `true`, do not notifies the error to user by showing the message box. Default is `false`.
+	 */
+	donotNotifyError?: boolean;
+}
+
 export interface IConfigurationEditingService {
 
 	_serviceBrand: ServiceIdentifier<any>;
@@ -69,5 +80,5 @@ export interface IConfigurationEditingService {
 	 * Allows to write the configuration value to either the user or workspace configuration file and save it if asked to save.
 	 * The returned promise will be in error state in any of the error cases from [ConfigurationEditingErrorCode](#ConfigurationEditingErrorCode)
 	 */
-	writeConfiguration(target: ConfigurationTarget, value: IConfigurationValue, save?: boolean): TPromise<void>;
+	writeConfiguration(target: ConfigurationTarget, value: IConfigurationValue, options?: IConfigurationEditingOptions): TPromise<void>;
 }
\ No newline at end of file

src/vs/workbench/services/configuration/node/configurationEditingService.ts

@@ -26,7 +26,7 @@ import { IConfigurationService } from 'vs/platform/configuration/common/configur
 import { keyFromOverrideIdentifier } from 'vs/platform/configuration/common/model';
 import { WORKSPACE_CONFIG_DEFAULT_PATH, WORKSPACE_STANDALONE_CONFIGURATIONS } from 'vs/workbench/services/configuration/common/configuration';
 import { IFileService } from 'vs/platform/files/common/files';
-import { IConfigurationEditingService, ConfigurationEditingErrorCode, IConfigurationEditingError, ConfigurationTarget, IConfigurationValue } from 'vs/workbench/services/configuration/common/configurationEditing';
+import { IConfigurationEditingService, ConfigurationEditingErrorCode, IConfigurationEditingError, ConfigurationTarget, IConfigurationValue, IConfigurationEditingOptions } from 'vs/workbench/services/configuration/common/configurationEditing';
 import { ITextModelResolverService, ITextEditorModel } from 'vs/editor/common/services/resolverService';
 import { OVERRIDE_PROPERTY_PATTERN } from 'vs/platform/configuration/common/configurationRegistry';
 import { IChoiceService, IMessageService, Severity } from 'vs/platform/message/common/message';
@@ -62,15 +62,19 @@ export class ConfigurationEditingService implements IConfigurationEditingService
 		this.queue = new Queue<void>();
 	}
 
-	writeConfiguration(target: ConfigurationTarget, value: IConfigurationValue, save: boolean = true): TPromise<void> {
-		return this.queue.queue(() => this.doWriteConfiguration(target, value, save).then(() => null, error => this.onError(error, target))); // queue up writes to prevent race conditions
+	writeConfiguration(target: ConfigurationTarget, value: IConfigurationValue, options: IConfigurationEditingOptions = {}): TPromise<void> {
+		return this.queue.queue(() => this.doWriteConfiguration(target, value, options) // queue up writes to prevent race conditions
+			.then(() => null,
+			error => {
+				return options.donotNotifyError ? TPromise.wrapError(error) : this.onError(error, target);
+			}));
 	}
 
-	private doWriteConfiguration(target: ConfigurationTarget, value: IConfigurationValue, save: boolean): TPromise<void> {
+	private doWriteConfiguration(target: ConfigurationTarget, value: IConfigurationValue, options: IConfigurationEditingOptions): TPromise<void> {
 		const operation = this.getConfigurationEditOperation(target, value);
 
-		return this.resolveAndValidate(target, operation, save)
-			.then(reference => this.writeToBuffer(reference.object.textEditorModel, operation, save)
+		return this.resolveAndValidate(target, operation, !options.donotSave)
+			.then(reference => this.writeToBuffer(reference.object.textEditorModel, operation, !options.donotSave)
 				.then(() => reference.dispose()));
 	}