From 3a9b0ec334a024f577b7e2ac3a75a226af7a6951 Mon Sep 17 00:00:00 2001
From: Joao Moreno <jomo@microsoft.com>
Date: Tue, 26 Jul 2016 15:48:08 +0200
Subject: [PATCH] send extension installation duration

fixes #9739
---
 .../extensionsWorkbenchService.ts             | 64 ++++++++++++++++---
 1 file changed, 55 insertions(+), 9 deletions(-)

diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts
index 40888b7801b..3155ca1d205 100644
--- a/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts
+++ b/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts
@@ -123,13 +123,37 @@ function stripVersion(id: string): string {
 	return id.replace(/-\d+\.\d+\.\d+$/, '');
 }
 
+enum Operation {
+	Installing,
+	Updating,
+	Uninstalling
+}
+
+interface IActiveExtension {
+	id: string;
+	operation: Operation;
+	extension: Extension;
+	start: Date;
+}
+
+function toTelemetryEventName(operation: Operation) {
+	switch (operation) {
+		case Operation.Installing: return 'extensionGallery:install';
+		case Operation.Updating: return 'extensionGallery:update';
+		case Operation.Uninstalling: return 'extensionGallery:uninstall';
+	}
+
+	return '';
+}
+
 export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
 
 	private static SyncPeriod = 1000 * 60 * 60 * 12; // 12 hours
 
 	_serviceBrand: any;
 	private stateProvider: IExtensionStateProvider;
-	private installing: { id: string; extension: Extension; }[] = [];
+	private installing: IActiveExtension[] = [];
+	private uninstalling: IActiveExtension[] = [];
 	private installed: Extension[] = [];
 	private syncDelayer: ThrottledDelayer<void>;
 	private disposables: IDisposable[] = [];
@@ -148,6 +172,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
 		this.disposables.push(extensionService.onInstallExtension(({ id, gallery }) => this.onInstallExtension(id, gallery)));
 		this.disposables.push(extensionService.onDidInstallExtension(({ id, local, error }) => this.onDidInstallExtension(id, local, error)));
 		this.disposables.push(extensionService.onUninstallExtension(id => this.onUninstallExtension(id)));
+		this.disposables.push(extensionService.onDidUninstallExtension(id => this.onDidUninstallExtension(id)));
 
 		this.syncDelayer = new ThrottledDelayer<void>(ExtensionsWorkbenchService.SyncPeriod);
 
@@ -280,7 +305,10 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
 		}
 
 		extension.gallery = gallery;
-		this.installing.push({ id: stripVersion(id), extension });
+
+		const start = new Date();
+		const operation = Operation.Uninstalling;
+		this.installing.push({ id: stripVersion(id), operation, extension, start });
 
 		this._onChange.fire();
 	}
@@ -313,7 +341,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
 			}
 		}
 
-		this.reportTelemetry(extension, eventName, !error);
+		this.reportTelemetry(installing, !error);
 		this._onChange.fire();
 	}
 
@@ -326,10 +354,25 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
 			return;
 		}
 
-		this.reportTelemetry(extension, 'extensionGallery:uninstall', true);
+		const start = new Date();
+		const operation = Operation.Uninstalling;
+		const uninstalling = this.uninstalling.filter(e => e.id === id)[0] || { id, operation, extension, start };
+		this.uninstalling = [uninstalling, ...this.uninstalling.filter(e => e.id !== id)];
+
 		this._onChange.fire();
 	}
 
+	private onDidUninstallExtension(id: string): void {
+		const uninstalling = this.uninstalling.filter(e => e.id === id)[0];
+		this.uninstalling = this.uninstalling.filter(e => e.id !== id);
+
+		if (!uninstalling) {
+			return;
+		}
+
+		this.reportTelemetry(uninstalling, true);
+	}
+
 	private getExtensionState(extension: Extension): ExtensionState {
 		if (extension.gallery && this.installing.some(e => e.extension.gallery.id === extension.gallery.id)) {
 			return ExtensionState.Installing;
@@ -344,13 +387,13 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
 		return ExtensionState.Uninstalled;
 	}
 
-	private reportTelemetry(extension: Extension, eventName: string, success: boolean): void {
-		if (!extension) {
+	private reportTelemetry(active: IActiveExtension, success: boolean): void {
+		if (!active.extension) {
 			return;
 		}
 
-		const local = extension.local;
-		const gallery = extension.gallery;
+		const local = active.extension.local;
+		const gallery = active.extension.gallery;
 		let data = null;
 
 		if (gallery) {
@@ -373,7 +416,10 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
 			};
 		}
 
-		this.telemetryService.publicLog(eventName, assign(data, { success }));
+		const duration = new Date().getTime() - active.start.getTime();
+		const eventName = toTelemetryEventName(active.operation);
+
+		this.telemetryService.publicLog(eventName, assign(data, { success, duration }));
 	}
 
 	dispose(): void {
-- 
GitLab