提交 386a1301 编写于 作者: J Joao Moreno

use semver to compare versions

上级 a05a4fde
...@@ -26,6 +26,7 @@ import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; ...@@ -26,6 +26,7 @@ import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
import { ReloadWindowAction } from 'vs/workbench/electron-browser/actions'; import { ReloadWindowAction } from 'vs/workbench/electron-browser/actions';
import { HighlightedLabel } from 'vs/base/browser/ui/highlightedlabel/highlightedLabel'; import { HighlightedLabel } from 'vs/base/browser/ui/highlightedlabel/highlightedLabel';
import { Action } from 'vs/base/common/actions'; import { Action } from 'vs/base/common/actions';
import * as semver from 'semver';
import { ActionBar } from 'vs/base/browser/ui/actionbar/actionbar'; import { ActionBar } from 'vs/base/browser/ui/actionbar/actionbar';
import remote = require('remote'); import remote = require('remote');
const shell = remote.require('shell'); const shell = remote.require('shell');
...@@ -496,7 +497,7 @@ class ExtensionsUpdateModel implements IModel<IExtensionEntry> { ...@@ -496,7 +497,7 @@ class ExtensionsUpdateModel implements IModel<IExtensionEntry> {
.map(extension => ({ extension, highlights: getHighlights(input, extension) })) .map(extension => ({ extension, highlights: getHighlights(input, extension) }))
.filter(({ extension, highlights }) => { .filter(({ extension, highlights }) => {
const local = this.localExtensions.filter(local => extensionEquals(local, extension))[0]; const local = this.localExtensions.filter(local => extensionEquals(local, extension))[0];
return local && local.version < extension.version && !!highlights; return local && semver.lt(local.version, extension.version) && !!highlights;
}) })
.map(({ extension, highlights }: { extension: IExtension, highlights: IHighlights }) => { .map(({ extension, highlights }: { extension: IExtension, highlights: IHighlights }) => {
return { return {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册