From 31a5fb236ddeed969a0021a2f94e7695ffbfb66b Mon Sep 17 00:00:00 2001 From: Ramya Rao Date: Thu, 27 Apr 2017 21:58:15 -0700 Subject: [PATCH] Route emmet actions to extension (#25587) * Route emmet actions to extension * No need for settings --- .../workbench/parts/emmet/node/emmetActions.ts | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/emmet/node/emmetActions.ts b/src/vs/workbench/parts/emmet/node/emmetActions.ts index f812166d8b3..9f5b8e089b7 100644 --- a/src/vs/workbench/parts/emmet/node/emmetActions.ts +++ b/src/vs/workbench/parts/emmet/node/emmetActions.ts @@ -23,6 +23,7 @@ import * as pfs from 'vs/base/node/pfs'; import Severity from 'vs/base/common/severity'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { EditorContextKeys } from 'vs/editor/common/editorContextKeys'; +import { ICommandService, CommandsRegistry } from 'vs/platform/commands/common/commands'; interface IEmmetConfiguration { emmet: { @@ -235,6 +236,14 @@ export interface IEmmetActionOptions extends IActionOptions { export abstract class EmmetEditorAction extends EditorAction { + private actionMap = { + 'editor.emmet.action.removeTag': 'emmet.removeTag', + 'editor.emmet.action.updateTag': 'emmet.updateTag', + 'editor.emmet.action.matchingPair': 'emmet.matchTag', + 'editor.emmet.action.wrapWithAbbreviation': 'emmet.wrapWithAbbreviation', + 'editor.emmet.action.expandAbbreviation': 'emmet.expandAbbreviation' + }; + protected emmetActionName: string; constructor(opts: IEmmetActionOptions) { @@ -269,6 +278,12 @@ export abstract class EmmetEditorAction extends EditorAction { const contextService = accessor.get(IWorkspaceContextService); const workspaceRoot = contextService.getWorkspace() ? contextService.getWorkspace().resource.fsPath : ''; const telemetryService = accessor.get(ITelemetryService); + const commandService = accessor.get(ICommandService); + + let mappedCommand = this.actionMap[this.id]; + if (mappedCommand && CommandsRegistry.getCommand(mappedCommand)) { + return commandService.executeCommand(mappedCommand); + } return this._withGrammarContributions(extensionService).then((grammarContributions) => { @@ -296,7 +311,6 @@ export abstract class EmmetEditorAction extends EditorAction { this.runEmmetAction(accessor, new EmmetActionContext(editor, _emmet, editorAccessor)); }); editorAccessor.onAfterEmmetAction(); - telemetryService.publicLog('emmetActionCompleted', { action: this.emmetActionName }); }); }); -- GitLab