From 2e85ce75ad58bc2bd646e2e5c4ad62b26e0c9ac2 Mon Sep 17 00:00:00 2001
From: Benjamin Pasero <benjpas@microsoft.com>
Date: Thu, 13 Jun 2019 08:51:26 +0200
Subject: [PATCH] web - wire in userDataPath properly

---
 src/vs/code/browser/workbench/workbench.html | 1 +
 src/vs/workbench/browser/web.main.ts         | 9 +++++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/vs/code/browser/workbench/workbench.html b/src/vs/code/browser/workbench/workbench.html
index 30598e4a566..378b7f594bd 100644
--- a/src/vs/code/browser/workbench/workbench.html
+++ b/src/vs/code/browser/workbench/workbench.html
@@ -19,6 +19,7 @@
 			keybindingsPath: '{{KEYBINDINGS}}',
 			folderPath: '{{FOLDER}}',
 			workspacePath: '{{WORKSPACE}}',
+			userDataPath: '{{USER_DATA}}'
 		}
 	</script>
 
diff --git a/src/vs/workbench/browser/web.main.ts b/src/vs/workbench/browser/web.main.ts
index 0264fc6cadd..8823bca3d5f 100644
--- a/src/vs/workbench/browser/web.main.ts
+++ b/src/vs/workbench/browser/web.main.ts
@@ -33,8 +33,10 @@ import { WebResources } from 'vs/workbench/browser/web.resources';
 import { ISignService } from 'vs/platform/sign/common/sign';
 import { SignService } from 'vs/platform/sign/browser/signService';
 import { hash } from 'vs/base/common/hash';
+import { joinPath } from 'vs/base/common/resources';
 
 interface IWindowConfiguration {
+	userDataUri: URI;
 	settingsUri: URI;
 	keybindingsUri: URI;
 	remoteAuthority: string;
@@ -140,7 +142,7 @@ class CodeRendererMain extends Disposable {
 		const environmentService = new SimpleWorkbenchEnvironmentService();
 		environmentService.appRoot = '/web/';
 		environmentService.args = { _: [] };
-		environmentService.appSettingsHome = toResource('/web/settings');
+		environmentService.appSettingsHome = joinPath(this.configuration.userDataUri, 'User');
 		environmentService.settingsResource = this.configuration.settingsUri;
 		environmentService.keybindingsResource = this.configuration.keybindingsUri;
 		environmentService.logsPath = '/web/logs';
@@ -148,11 +150,11 @@ class CodeRendererMain extends Disposable {
 			port: null,
 			break: false
 		};
+
 		return environmentService;
 	}
 
 	private async createWorkspaceService(payload: IWorkspaceInitializationPayload, fileService: FileService, remoteAgentService: IRemoteAgentService, logService: ILogService): Promise<WorkspaceService> {
-
 		const workspaceService = new WorkspaceService({ userSettingsResource: this.configuration.settingsUri, remoteAuthority: this.configuration.remoteAuthority, configurationCache: new ConfigurationCache() }, new ConfigurationFileService(fileService), remoteAgentService);
 
 		try {
@@ -184,6 +186,7 @@ class CodeRendererMain extends Disposable {
 }
 
 export interface IWindowConfigurationContents {
+	userDataPath: string;
 	settingsPath: string;
 	keybindingsPath: string;
 	folderPath?: string;
@@ -192,12 +195,14 @@ export interface IWindowConfigurationContents {
 
 export function main(windowConfigurationContents: IWindowConfigurationContents): Promise<void> {
 	const windowConfiguration: IWindowConfiguration = {
+		userDataUri: toResource(windowConfigurationContents.userDataPath),
 		settingsUri: toResource(windowConfigurationContents.settingsPath),
 		keybindingsUri: toResource(windowConfigurationContents.keybindingsPath),
 		folderUri: windowConfigurationContents.folderPath ? toResource(windowConfigurationContents.folderPath) : undefined,
 		workspaceUri: windowConfigurationContents.workspacePath ? toResource(windowConfigurationContents.workspacePath) : undefined,
 		remoteAuthority: document.location.host
 	};
+
 	const renderer = new CodeRendererMain(windowConfiguration);
 	return renderer.open();
 }
-- 
GitLab