From 2e80a8f99e239a712d58081b2fbc6ceafd03f176 Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Mon, 4 May 2020 09:24:25 +0200 Subject: [PATCH] add comment why sync state should be scoped --- .../services/environment/browser/environmentService.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/vs/workbench/services/environment/browser/environmentService.ts b/src/vs/workbench/services/environment/browser/environmentService.ts index 16da86c4af1..5ef5e22577d 100644 --- a/src/vs/workbench/services/environment/browser/environmentService.ts +++ b/src/vs/workbench/services/environment/browser/environmentService.ts @@ -114,6 +114,11 @@ export class BrowserWorkbenchEnvironmentService implements IWorkbenchEnvironment @memoize get snippetsHome(): URI { return joinPath(this.userRoamingDataHome, 'snippets'); } + /* + * In Web every workspace can potentially have scoped user-data and/or extensions and if Sync state is shared then it can make + * Sync error prone - say removing extensions from another workspace. Hence scope Sync state per workspace. + * Sync scoped to a workspace is capable of handling even if workspaces/windows share same user data and extensions. + */ @memoize get userDataSyncHome(): URI { return joinPath(this.userRoamingDataHome, 'sync', this.options.workspaceId); } -- GitLab