From 297f871efa903e9dd3ec9aeb90bbe65ef4bd7485 Mon Sep 17 00:00:00 2001 From: Julia McGeoghan Date: Fri, 21 Dec 2018 08:50:23 -0500 Subject: [PATCH] Enable strict null checking for node/flow test (#65541) * flow-test-fix * flow-test-fix * Revert "flow-test-fix" This reverts commit 4f0c4beddce05f85026308cbe6652e2389f91435. --- src/tsconfig.strictNullChecks.json | 2 ++ src/vs/base/node/flow.ts | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json index cbc1cadb439..0a4ca61c962 100644 --- a/src/tsconfig.strictNullChecks.json +++ b/src/tsconfig.strictNullChecks.json @@ -137,6 +137,7 @@ "./vs/base/test/common/json.test.ts", "./vs/base/test/common/jsonEdit.test.ts", "./vs/base/test/common/jsonFormatter.test.ts", + "./vs/base/test/common/labels.test.ts", "./vs/base/test/common/lifecycle.test.ts", "./vs/base/test/common/linkedList.test.ts", @@ -159,6 +160,7 @@ "./vs/base/test/node/decoder.test.ts", "./vs/base/test/node/encoding/encoding.test.ts", "./vs/base/test/node/extfs/extfs.test.ts", + "./vs/base/test/node/flow.test.ts", "./vs/base/test/node/id.test.ts", "./vs/base/test/node/glob.test.ts", "./vs/base/test/node/port.test.ts", diff --git a/src/vs/base/node/flow.ts b/src/vs/base/node/flow.ts index 6214d738c0a..c1232c2993b 100644 --- a/src/vs/base/node/flow.ts +++ b/src/vs/base/node/flow.ts @@ -9,7 +9,7 @@ import * as assert from 'assert'; * Executes the given function (fn) over the given array of items (list) in parallel and returns the resulting errors and results as * array to the callback (callback). The resulting errors and results are evaluated by calling the provided callback function. */ -export function parallel(list: T[], fn: (item: T, callback: (err: Error, result: E) => void) => void, callback: (err: Array | null, result: E[]) => void): void { +export function parallel(list: T[], fn: (item: T, callback: (err: Error | null, result: E | null) => void) => void, callback: (err: Array | null, result: E[]) => void): void { let results = new Array(list.length); let errors = new Array(list.length); let didErrorOccur = false; -- GitLab