From 232d83f392a7b2088c077d70dec57c3f3c52c562 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Fri, 17 Nov 2017 17:52:51 +0100 Subject: [PATCH] Fix of "Cannot read property 'filter' of undefined" in extensionGalleryService. This fixes #38635 and fixes #38357 --- .../node/extensionGalleryService.ts | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/vs/platform/extensionManagement/node/extensionGalleryService.ts b/src/vs/platform/extensionManagement/node/extensionGalleryService.ts index c46718b0640..0ca82828556 100644 --- a/src/vs/platform/extensionManagement/node/extensionGalleryService.ts +++ b/src/vs/platform/extensionManagement/node/extensionGalleryService.ts @@ -202,22 +202,23 @@ function getVersionAsset(version: IRawGalleryExtensionVersion, type: string): IG const result = version.files.filter(f => f.assetType === type)[0]; if (type === AssetType.Repository) { - const results = version.properties.filter(p => p.key === type); - const gitRegExp = new RegExp('((git|ssh|http(s)?)|(git@[\w\.]+))(:(//)?)([\w\.@\:/\-~]+)(\.git)(/)?'); + if (version.properties) { + const results = version.properties.filter(p => p.key === type); + const gitRegExp = new RegExp('((git|ssh|http(s)?)|(git@[\w\.]+))(:(//)?)([\w\.@\:/\-~]+)(\.git)(/)?'); + + const uri = results.filter(r => gitRegExp.test(r.value))[0]; + if (!uri) { + return { + uri: null, + fallbackUri: null + }; + } - const uri = results.filter(r => gitRegExp.test(r.value))[0]; - if (!uri) { return { - uri: null, - fallbackUri: null + uri: uri.value, + fallbackUri: uri.value, }; } - - return { - uri: uri.value, - fallbackUri: uri.value, - }; - } if (!result) { -- GitLab