From 1ce89e2cb720d69c496c2815c4696ee4fd4429a6 Mon Sep 17 00:00:00 2001
From: Matt Bierner <matb@microsoft.com>
Date: Thu, 15 Aug 2019 18:20:21 -0700
Subject: [PATCH] Removing test for disposable store

We have disabled this behavior
---
 src/vs/base/test/common/lifecycle.test.ts | 36 ++---------------------
 1 file changed, 2 insertions(+), 34 deletions(-)

diff --git a/src/vs/base/test/common/lifecycle.test.ts b/src/vs/base/test/common/lifecycle.test.ts
index 46d8a254b5b..4d15ad2046c 100644
--- a/src/vs/base/test/common/lifecycle.test.ts
+++ b/src/vs/base/test/common/lifecycle.test.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 import * as assert from 'assert';
-import { IDisposable, dispose, ReferenceCollection, Disposable as DisposableBase, toDisposable } from 'vs/base/common/lifecycle';
+import { IDisposable, dispose, ReferenceCollection } from 'vs/base/common/lifecycle';
 
 class Disposable implements IDisposable {
 	isDisposed = false;
@@ -50,38 +50,6 @@ suite('Lifecycle', () => {
 	});
 });
 
-suite('DisposableBase', () => {
-	test('register should not leak if object has already been disposed', () => {
-		let aCount = 0;
-		let bCount = 0;
-
-		const disposable = new class extends DisposableBase {
-			register(other: IDisposable) {
-				this._register(other);
-			}
-		};
-
-		disposable.register(toDisposable(() => ++aCount));
-
-		assert.strictEqual(aCount, 0);
-		assert.strictEqual(bCount, 0);
-
-		disposable.dispose();
-		assert.strictEqual(aCount, 1);
-		assert.strictEqual(bCount, 0);
-
-		// Any newly added disposables should be disposed of immediately
-		disposable.register(toDisposable(() => ++bCount));
-		assert.strictEqual(aCount, 1);
-		assert.strictEqual(bCount, 1);
-
-		// Further dispose calls should have no effect
-		disposable.dispose();
-		assert.strictEqual(aCount, 1);
-		assert.strictEqual(bCount, 1);
-	});
-});
-
 suite('Reference Collection', () => {
 	class Collection extends ReferenceCollection<number> {
 		private _count = 0;
@@ -118,4 +86,4 @@ suite('Reference Collection', () => {
 		ref4.dispose();
 		assert.equal(collection.count, 0);
 	});
-});
\ No newline at end of file
+});
-- 
GitLab