From 1be0f0b9347f2797d7569988626c1e6fa9886042 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Wed, 15 Jan 2020 17:07:40 +0100 Subject: [PATCH] bulk: return early if edit does nothing --- src/vs/workbench/services/bulkEdit/browser/bulkEditService.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/vs/workbench/services/bulkEdit/browser/bulkEditService.ts b/src/vs/workbench/services/bulkEdit/browser/bulkEditService.ts index 11136917170..3a0d834deb7 100644 --- a/src/vs/workbench/services/bulkEdit/browser/bulkEditService.ts +++ b/src/vs/workbench/services/bulkEdit/browser/bulkEditService.ts @@ -389,6 +389,10 @@ export class BulkEditService implements IBulkEditService { async apply(edit: WorkspaceEdit, options?: IBulkEditOptions): Promise { + if (edit.edits.length === 0) { + return { ariaSummary: localize('nothing', "Made no edits") }; + } + if (this._previewHandler && options?.showPreview) { edit = await this._previewHandler(edit, options); } -- GitLab