From 198115388b6c93ad38a115791025a7204caecae3 Mon Sep 17 00:00:00 2001 From: kieferrm Date: Fri, 9 Mar 2018 17:40:58 -0800 Subject: [PATCH] update classification --- .../extensionManagement/common/extensionManagement.ts | 6 ++++++ src/vs/platform/telemetry/common/telemetryUtils.ts | 2 +- .../parts/extensions/electron-browser/extensionsUtils.ts | 2 +- src/vs/workbench/parts/stats/node/workspaceStats.ts | 2 +- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/vs/platform/extensionManagement/common/extensionManagement.ts b/src/vs/platform/extensionManagement/common/extensionManagement.ts index 4951973eae1..06403239f22 100644 --- a/src/vs/platform/extensionManagement/common/extensionManagement.ts +++ b/src/vs/platform/extensionManagement/common/extensionManagement.ts @@ -146,6 +146,12 @@ export function isIExtensionIdentifier(thing: any): thing is IExtensionIdentifie && (!thing.uuid || typeof thing.uuid === 'string'); } +/* __GDPR__FRAGMENT__ + "ExtensionIdentifier" : { + "id" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, + "uuid": { "classification": "SystemMetaData", "purpose": "FeatureInsight" } + } + */ export interface IExtensionIdentifier { id: string; uuid?: string; diff --git a/src/vs/platform/telemetry/common/telemetryUtils.ts b/src/vs/platform/telemetry/common/telemetryUtils.ts index a5b2fb56bec..c911a2beec7 100644 --- a/src/vs/platform/telemetry/common/telemetryUtils.ts +++ b/src/vs/platform/telemetry/common/telemetryUtils.ts @@ -42,7 +42,7 @@ export const NullAppender: ITelemetryAppender = { log: () => null }; "URIDescriptor" : { "mimeType" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "ext": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, - "path": { "classification": "CustomerContent", "purpose": "FeatureInsight" } + "path": { "classification": "SystemMetaData", "purpose": "FeatureInsight" } } */ export interface URIDescriptor { diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsUtils.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsUtils.ts index 95198ffb489..084a79f179a 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionsUtils.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionsUtils.ts @@ -79,7 +79,7 @@ export class KeymapExtensions implements IWorkbenchContribution { }; /* __GDPR__ "disableOtherKeymaps" : { - "newKeymap" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, + "newKeymap": { "${inline}": [ "${ExtensionIdentifier}" ] }, "oldKeymaps": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "confirmed" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true } } diff --git a/src/vs/workbench/parts/stats/node/workspaceStats.ts b/src/vs/workbench/parts/stats/node/workspaceStats.ts index 79038045ada..eab17a15eec 100644 --- a/src/vs/workbench/parts/stats/node/workspaceStats.ts +++ b/src/vs/workbench/parts/stats/node/workspaceStats.ts @@ -372,7 +372,7 @@ export class WorkspaceStats implements IWorkbenchContribution { })).then(hashedRemotes => { /* __GDPR__ "workspace.hashedRemotes" : { - "remotes" : { "classification": "CustomerContent", "purpose": "FeatureInsight" } + "remotes" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" } } */ this.telemetryService.publicLog('workspace.hashedRemotes', { remotes: hashedRemotes }); -- GitLab