diff --git a/src/vs/workbench/contrib/debug/browser/debug.contribution.ts b/src/vs/workbench/contrib/debug/browser/debug.contribution.ts index cfe54f206455aaaa5d01a8f585917fa3b7d2c952..f89ac5a0857a45a5781c7df9d2cde03af0d813e0 100644 --- a/src/vs/workbench/contrib/debug/browser/debug.contribution.ts +++ b/src/vs/workbench/contrib/debug/browser/debug.contribution.ts @@ -229,11 +229,6 @@ configurationRegistry.registerConfiguration({ default: 'openOnSessionStart', description: nls.localize('openDebug', "Controls when the debug view should open.") }, - 'debug.enableAllHovers': { - type: 'boolean', - description: nls.localize({ comment: ['This is the description for a setting'], key: 'enableAllHovers' }, "Controls whether the non-debug hovers should be enabled while debugging. When enabled the hover providers will be called to provide a hover. Regular hovers will not be shown even if this setting is enabled."), - default: false - }, 'debug.showSubSessionsInToolBar': { type: 'boolean', description: nls.localize({ comment: ['This is the description for a setting'], key: 'showSubSessionsInToolBar' }, "Controls whether the debug sub-sessions are shown in the debug tool bar. When this setting is false the stop command on a sub-session will also stop the parent session."), diff --git a/src/vs/workbench/contrib/debug/browser/debugEditorContribution.ts b/src/vs/workbench/contrib/debug/browser/debugEditorContribution.ts index e0b468a677c28337c67fa086889d9e3d30d43750..711e00f179deb07e9bb81735f89e34e8cbbea975 100644 --- a/src/vs/workbench/contrib/debug/browser/debugEditorContribution.ts +++ b/src/vs/workbench/contrib/debug/browser/debugEditorContribution.ts @@ -30,10 +30,8 @@ import { CoreEditingCommands } from 'vs/editor/browser/controller/coreCommands'; import { first } from 'vs/base/common/arrays'; import { memoize, createMemoizer } from 'vs/base/common/decorators'; import { IEditorHoverOptions, EditorOption } from 'vs/editor/common/config/editorOptions'; -import { CancellationToken } from 'vs/base/common/cancellation'; import { DebugHoverWidget } from 'vs/workbench/contrib/debug/browser/debugHover'; import { ITextModel } from 'vs/editor/common/model'; -import { getHover } from 'vs/editor/contrib/hover/getHover'; import { dispose, IDisposable } from 'vs/base/common/lifecycle'; import { EditOperation } from 'vs/editor/common/core/editOperation'; import { basename } from 'vs/base/common/path'; @@ -170,7 +168,6 @@ class DebugEditorContribution implements IDebugEditorContribution { private toDispose: IDisposable[]; private hoverWidget: DebugHoverWidget; - private nonDebugHoverPosition: Position | undefined; private hoverRange: Range | null = null; private mouseDown = false; private static readonly MEMOIZER = createMemoizer(); @@ -204,7 +201,6 @@ class DebugEditorContribution implements IDebugEditorContribution { this.toDispose.push(this.editor.onMouseUp(() => this.mouseDown = false)); this.toDispose.push(this.editor.onMouseMove((e: IEditorMouseEvent) => this.onEditorMouseMove(e))); this.toDispose.push(this.editor.onMouseLeave((e: IPartialEditorMouseEvent) => { - this.provideNonDebugHoverScheduler.cancel(); const hoverDomNode = this.hoverWidget.getDomNode(); if (!hoverDomNode) { return; @@ -315,24 +311,11 @@ class DebugEditorContribution implements IDebugEditorContribution { return scheduler; } - @memoize - private get provideNonDebugHoverScheduler(): RunOnceScheduler { - const scheduler = new RunOnceScheduler(() => { - if (this.editor.hasModel() && this.nonDebugHoverPosition) { - getHover(this.editor.getModel(), this.nonDebugHoverPosition, CancellationToken.None); - } - }, HOVER_DELAY); - this.toDispose.push(scheduler); - - return scheduler; - } - private hideHoverWidget(): void { if (!this.hideHoverScheduler.isScheduled() && this.hoverWidget.isVisible()) { this.hideHoverScheduler.schedule(); } this.showHoverScheduler.cancel(); - this.provideNonDebugHoverScheduler.cancel(); } // hover business @@ -351,10 +334,6 @@ class DebugEditorContribution implements IDebugEditorContribution { return; } - if (this.configurationService.getValue('debug').enableAllHovers && mouseEvent.target.position) { - this.nonDebugHoverPosition = mouseEvent.target.position; - this.provideNonDebugHoverScheduler.schedule(); - } const targetType = mouseEvent.target.type; const stopKey = env.isMacintosh ? 'metaKey' : 'ctrlKey';