From 18cf7818450b8704744e22c223ba731a707744a3 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Mon, 12 Nov 2018 14:15:34 -0800 Subject: [PATCH] Strict null check extensionsAutoProfiler --- src/tsconfig.strictNullChecks.json | 1 + .../extensions/electron-browser/extensionsAutoProfiler.ts | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json index afe26f89aa6..7dc3f045fed 100644 --- a/src/tsconfig.strictNullChecks.json +++ b/src/tsconfig.strictNullChecks.json @@ -598,6 +598,7 @@ "./vs/workbench/parts/extensions/common/extensions.ts", "./vs/workbench/parts/extensions/common/extensionsFileTemplate.ts", "./vs/workbench/parts/extensions/electron-browser/extensionsActivationProgress.ts", + "./vs/workbench/parts/extensions/electron-browser/extensionsAutoProfiler.ts", "./vs/workbench/parts/extensions/electron-browser/extensionsUtils.ts", "./vs/workbench/parts/logs/common/logConstants.ts", "./vs/workbench/parts/logs/electron-browser/logs.contribution.ts", diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsAutoProfiler.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsAutoProfiler.ts index c98b11410cd..87206efd202 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionsAutoProfiler.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionsAutoProfiler.ts @@ -81,7 +81,7 @@ export class ExtensionsAutoProfiler extends Disposable implements IWorkbenchCont const duration = profile.endTime - profile.startTime; const percentage = duration / 100; - let top: NamedSlice; + let top: NamedSlice | undefined; for (const slice of data) { slice.percentage = Math.round(slice.total / percentage); if (!top || top.percentage < slice.percentage) { @@ -89,7 +89,7 @@ export class ExtensionsAutoProfiler extends Disposable implements IWorkbenchCont } } - this._logService.warn(`UNRESPONSIVE extension host, '${top.id}' took ${top.percentage}% of ${duration / 1e3}ms`, data); + this._logService.warn(`UNRESPONSIVE extension host, '${top ? top.id : 'unknown'}' took ${top ? top.percentage : 'unknown'}% of ${duration / 1e3}ms`, data); /* __GDPR__ "exthostunresponsive" : { -- GitLab