diff --git a/src/vs/workbench/parts/walkThrough/electron-browser/walkThroughPart.ts b/src/vs/workbench/parts/walkThrough/electron-browser/walkThroughPart.ts index b53d9f02892a41b15259797569b57497a17d282e..4e820af08428cb8939fcff8e6d7f15b4cfd6ad5c 100644 --- a/src/vs/workbench/parts/walkThrough/electron-browser/walkThroughPart.ts +++ b/src/vs/workbench/parts/walkThrough/electron-browser/walkThroughPart.ts @@ -111,6 +111,11 @@ export class WalkThroughPart extends BaseEditor { layout({ width, height }: Dimension): void { $(this.content).style({ height: `${height}px`, width: `${width}px` }); + const innerContent = this.content.firstElementChild; + if (innerContent) { + const classList = innerContent.classList; + classList[height <= 690 ? 'add' : 'remove']('max-height-690px'); + } this.contentDisposables.forEach(disposable => { if (disposable instanceof CodeEditor) { disposable.layout(); @@ -137,7 +142,7 @@ export class WalkThroughPart extends BaseEditor { this.content.innerHTML = content; this.decorateContent(); if (input.onReady) { - input.onReady(this.content); + input.onReady(this.content.firstElementChild as HTMLElement); } this.scrollbar.scanDomNode(); return; @@ -149,14 +154,16 @@ export class WalkThroughPart extends BaseEditor { const id = `snippet-${model.snippets[i++].textEditorModel.uri.fragment}`; return `
`; }; - this.content.classList.add('walkThroughContent'); // only for markdown files + const innerContent = document.createElement('div'); + innerContent.classList.add('walkThroughContent'); // only for markdown files const markdown = this.expandMacros(content); - this.content.innerHTML = marked(markdown, { renderer }); + innerContent.innerHTML = marked(markdown, { renderer }); + this.content.appendChild(innerContent); model.snippets.forEach((snippet, i) => { const model = snippet.textEditorModel; const id = `snippet-${model.uri.fragment}`; - const div = this.content.querySelector(`#${id.replace(/\./g, '\\.')}`) as HTMLElement; + const div = innerContent.querySelector(`#${id.replace(/\./g, '\\.')}`) as HTMLElement; var options: IEditorOptions = { scrollBeyondLastLine: false, @@ -184,7 +191,7 @@ export class WalkThroughPart extends BaseEditor { } }); if (input.onReady) { - input.onReady(this.content); + input.onReady(innerContent); } this.scrollbar.scanDomNode(); }); diff --git a/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.css b/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.css index be959c8cd4f0c685d6f6b534f5b4a6b1abf20c0a..e39561ad2fc94d2cb860ed401ec738ecb10cebbb 100644 --- a/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.css +++ b/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.css @@ -37,9 +37,14 @@ } .monaco-workbench > .part.editor > .content .welcomePage a { - color: #4080D0; + color: #2e70c0; text-decoration: none; } + +.vs-dark .monaco-workbench > .part.editor > .content .welcomePage a { + color: #4080D0; +} + .monaco-workbench > .part.editor > .content .welcomePage a:focus { outline: 1px solid -webkit-focus-ring-color; outline-offset: -1px; @@ -222,8 +227,6 @@ outline-offset: -5px; } -@media screen and (max-height: 750px) { - .monaco-workbench > .part.editor > .content .welcomePage .title { - display: none; - } -} \ No newline at end of file +.monaco-workbench > .part.editor > .content .welcomePage.max-height-690px .title { + display: none; +} diff --git a/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.ts b/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.ts index d00df9156cf6e47fec5be219307c9ddd4fabe2b2..d73f9334b02994f06bcdd6e49658b6f907092388 100644 --- a/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.ts +++ b/src/vs/workbench/parts/welcomePage/electron-browser/welcomePage.ts @@ -125,6 +125,7 @@ class WelcomePage { a.addEventListener('click', e => { this.windowsService.openWindow([folder]); e.preventDefault(); + e.stopPropagation(); }); li.appendChild(a);