From 13921a8ecabc877281a955486162d1b3f6f19695 Mon Sep 17 00:00:00 2001 From: Rachel Macfarlane Date: Tue, 18 Dec 2018 09:34:42 -0800 Subject: [PATCH] Properly dispose of deleted comment zone widgets on comment update event --- .../comments/electron-browser/commentsEditorContribution.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vs/workbench/parts/comments/electron-browser/commentsEditorContribution.ts b/src/vs/workbench/parts/comments/electron-browser/commentsEditorContribution.ts index bb6bbe74b9f..1d3a49b5775 100644 --- a/src/vs/workbench/parts/comments/electron-browser/commentsEditorContribution.ts +++ b/src/vs/workbench/parts/comments/electron-browser/commentsEditorContribution.ts @@ -381,6 +381,7 @@ export class ReviewController implements IEditorContribution { let matchedZone = matchedZones[0]; let index = this._commentWidgets.indexOf(matchedZone); this._commentWidgets.splice(index, 1); + matchedZone.dispose(); } }); -- GitLab