From 126e49379d01e8c912de89d6800e0d84c71fe137 Mon Sep 17 00:00:00 2001
From: Benjamin Pasero <benjpas@microsoft.com>
Date: Fri, 13 Sep 2019 08:26:58 +0200
Subject: [PATCH] web - extract no-op tunnel service

---
 .../remote/{node => common}/tunnelService.ts       |  5 +----
 src/vs/workbench/browser/web.simpleservices.ts     | 14 --------------
 src/vs/workbench/workbench.web.main.ts             |  3 +++
 3 files changed, 4 insertions(+), 18 deletions(-)
 rename src/vs/platform/remote/{node => common}/tunnelService.ts (75%)

diff --git a/src/vs/platform/remote/node/tunnelService.ts b/src/vs/platform/remote/common/tunnelService.ts
similarity index 75%
rename from src/vs/platform/remote/node/tunnelService.ts
rename to src/vs/platform/remote/common/tunnelService.ts
index f9126aa719d..ac9f17c9077 100644
--- a/src/vs/platform/remote/node/tunnelService.ts
+++ b/src/vs/platform/remote/common/tunnelService.ts
@@ -4,9 +4,8 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { ITunnelService, RemoteTunnel } from 'vs/platform/remote/common/tunnel';
-import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
 
-export class TunnelService implements ITunnelService {
+export class NoOpTunnelService implements ITunnelService {
 	_serviceBrand: undefined;
 
 	public constructor(
@@ -17,5 +16,3 @@ export class TunnelService implements ITunnelService {
 		return undefined;
 	}
 }
-
-registerSingleton(ITunnelService, TunnelService);
diff --git a/src/vs/workbench/browser/web.simpleservices.ts b/src/vs/workbench/browser/web.simpleservices.ts
index b02fbdb43fb..3a836c8772b 100644
--- a/src/vs/workbench/browser/web.simpleservices.ts
+++ b/src/vs/workbench/browser/web.simpleservices.ts
@@ -15,7 +15,6 @@ import { IWorkspaceIdentifier, ISingleFolderWorkspaceIdentifier, IWorkspaceFolde
 import { IRecentlyOpened, IRecent, isRecentFile, isRecentFolder } from 'vs/platform/history/common/history';
 import { ISerializableCommandAction } from 'vs/platform/actions/common/actions';
 import { IWorkspaceEditingService } from 'vs/workbench/services/workspace/common/workspaceEditing';
-import { ITunnelService } from 'vs/platform/remote/common/tunnel';
 import { IWorkspaceContextService, WorkbenchState, IWorkspace } from 'vs/platform/workspace/common/workspace';
 import { addDisposableListener, EventType, windowOpenNoOpener } from 'vs/base/browser/dom';
 import { IEditorService, IResourceEditor } from 'vs/workbench/services/editor/common/editorService';
@@ -683,19 +682,6 @@ registerSingleton(IWorkspacesService, SimpleWorkspacesService);
 
 //#endregion
 
-//#region remote
-
-class SimpleTunnelService implements ITunnelService {
-	_serviceBrand: undefined;
-	openTunnel(remotePort: number) {
-		return undefined;
-	}
-}
-
-registerSingleton(ITunnelService, SimpleTunnelService);
-
-//#endregion
-
 //#region workspace stats
 
 class SimpleWorkspaceStatsService implements IWorkspaceStatsService {
diff --git a/src/vs/workbench/workbench.web.main.ts b/src/vs/workbench/workbench.web.main.ts
index 0ddb3198002..c72bac33876 100644
--- a/src/vs/workbench/workbench.web.main.ts
+++ b/src/vs/workbench/workbench.web.main.ts
@@ -58,6 +58,8 @@ import { ContextMenuService } from 'vs/platform/contextview/browser/contextMenuS
 import { IBackupFileService } from 'vs/workbench/services/backup/common/backup';
 import { BackupFileService } from 'vs/workbench/services/backup/common/backupFileService';
 import { ExtensionManagementService } from 'vs/workbench/services/extensionManagement/common/extensionManagementService';
+import { ITunnelService } from 'vs/platform/remote/common/tunnel';
+import { NoOpTunnelService } from 'vs/platform/remote/common/tunnelService';
 
 registerSingleton(IRequestService, RequestService, true);
 registerSingleton(IExtensionManagementService, ExtensionManagementService);
@@ -67,6 +69,7 @@ registerSingleton(IClipboardService, BrowserClipboardService, true);
 registerSingleton(IAccessibilityService, BrowserAccessibilityService, true);
 registerSingleton(ILifecycleService, BrowserLifecycleService);
 registerSingleton(IContextMenuService, ContextMenuService);
+registerSingleton(ITunnelService, NoOpTunnelService, true);
 
 //#endregion
 
-- 
GitLab