From 11f2cb7779a6ad56d7dc91e06747da6f3d4820a2 Mon Sep 17 00:00:00 2001
From: Rob Lourens <roblourens@gmail.com>
Date: Fri, 8 May 2020 16:58:32 -0500
Subject: [PATCH] Don't show validations for invalid setting defaults Fix
 #97034

---
 src/vs/workbench/contrib/preferences/browser/settingsTree.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/vs/workbench/contrib/preferences/browser/settingsTree.ts b/src/vs/workbench/contrib/preferences/browser/settingsTree.ts
index 21738f1e575..495a328ae6f 100644
--- a/src/vs/workbench/contrib/preferences/browser/settingsTree.ts
+++ b/src/vs/workbench/contrib/preferences/browser/settingsTree.ts
@@ -740,7 +740,7 @@ export class SettingComplexRenderer extends AbstractSettingRenderer implements I
 	}
 
 	private renderValidations(dataElement: SettingsTreeSettingElement, template: ISettingComplexItemTemplate) {
-		const errMsg = getInvalidTypeError(dataElement.value, dataElement.setting.type);
+		const errMsg = dataElement.isConfigured && getInvalidTypeError(dataElement.value, dataElement.setting.type);
 		if (errMsg) {
 			DOM.addClass(template.containerElement, 'invalid-input');
 			template.validationErrorMessageElement.innerText = errMsg;
@@ -1486,7 +1486,7 @@ class SettingsTreeDelegate extends CachedListVirtualDelegate<SettingsTreeGroupCh
 		}
 
 		if (element instanceof SettingsTreeSettingElement) {
-			const invalidTypeError = getInvalidTypeError(element.value, element.setting.type);
+			const invalidTypeError = element.isConfigured && getInvalidTypeError(element.value, element.setting.type);
 			if (invalidTypeError) {
 				return SETTINGS_COMPLEX_TEMPLATE_ID;
 			}
-- 
GitLab