From 1035cd0448ac4dde6096590f336860f677c28a53 Mon Sep 17 00:00:00 2001 From: isidor Date: Fri, 8 Jan 2016 16:55:01 +0100 Subject: [PATCH] debug: clear breakpoint soure raw source reference on debug session end --- .../parts/debug/electron-browser/debugService.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/parts/debug/electron-browser/debugService.ts b/src/vs/workbench/parts/debug/electron-browser/debugService.ts index 2c5a5d53c25..707511d9677 100644 --- a/src/vs/workbench/parts/debug/electron-browser/debugService.ts +++ b/src/vs/workbench/parts/debug/electron-browser/debugService.ts @@ -312,8 +312,6 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService private loadBreakpoints(): debug.IBreakpoint[] { try { return JSON.parse(this.storageService.get(DEBUG_BREAKPOINTS_KEY, StorageScope.WORKSPACE, '[]')).map((breakpoint: any) => { - // Source reference changes across sessions, so we do not use it to persist the source. - delete breakpoint.source.raw.sourceReference; return new model.Breakpoint(new Source(breakpoint.source.raw ? breakpoint.source.raw : { path: uri.parse(breakpoint.source.uri).fsPath, name: breakpoint.source.name }), breakpoint.desiredLineNumber || breakpoint.lineNumber, breakpoint.enabled, breakpoint.condition); }); @@ -631,8 +629,12 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService this.setStateAndEmit(debug.State.Inactive); // set breakpoints back to unverified since the session ended. + // source reference changes across sessions, so we do not use it to persist the source. const data: {[id: string]: { line: number, verified: boolean } } = { }; - this.model.getBreakpoints().forEach(bp => data[bp.getId()] = { line: bp.lineNumber, verified: false }); + this.model.getBreakpoints().forEach(bp => { + delete bp.source.raw.sourceReference; + data[bp.getId()] = { line: bp.lineNumber, verified: false }; + }); this.model.updateBreakpoints(data); this.inDebugMode.reset(); -- GitLab