From 0ffc6dbd74cc2ac9d877519399ceba34dea8461e Mon Sep 17 00:00:00 2001 From: Joao Moreno Date: Mon, 19 Nov 2018 15:23:37 +0100 Subject: [PATCH] strict null checks --- src/vs/base/browser/ui/list/listView.ts | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/vs/base/browser/ui/list/listView.ts b/src/vs/base/browser/ui/list/listView.ts index 98ca71fe5f0..0a96472dba2 100644 --- a/src/vs/base/browser/ui/list/listView.ts +++ b/src/vs/base/browser/ui/list/listView.ts @@ -344,17 +344,17 @@ export class ListView implements ISpliceable, IDisposable { } private updateItemInDOM(item: IItem, index: number): void { - item.row.domNode!.style.top = `${this.elementTop(index)}px`; - item.row.domNode!.style.height = `${item.size}px`; + item.row!.domNode!.style.top = `${this.elementTop(index)}px`; + item.row!.domNode!.style.height = `${item.size}px`; if (this.setRowLineHeight) { - item.row.domNode!.style.lineHeight = `${item.size}px`; + item.row!.domNode!.style.lineHeight = `${item.size}px`; } - item.row.domNode!.setAttribute('data-index', `${index}`); - item.row.domNode!.setAttribute('data-last-element', index === this.length - 1 ? 'true' : 'false'); - item.row.domNode!.setAttribute('aria-setsize', `${this.length}`); - item.row.domNode!.setAttribute('aria-posinset', `${index + 1}`); + item.row!.domNode!.setAttribute('data-index', `${index}`); + item.row!.domNode!.setAttribute('data-last-element', index === this.length - 1 ? 'true' : 'false'); + item.row!.domNode!.setAttribute('aria-setsize', `${this.length}`); + item.row!.domNode!.setAttribute('aria-posinset', `${index + 1}`); } private removeItemFromDOM(index: number): void { @@ -583,7 +583,7 @@ export class ListView implements ISpliceable, IDisposable { } if (typeof secondElementIndex === 'number') { - this.scrollTop = this.elementTop(secondElementIndex) - secondElementTopDelta; + this.scrollTop = this.elementTop(secondElementIndex) - secondElementTopDelta!; } return; @@ -603,12 +603,12 @@ export class ListView implements ISpliceable, IDisposable { const renderer = this.renderers.get(item.templateId); const row = this.cache.alloc(item.templateId); - row.domNode.style.height = ''; - this.rowsContainer.appendChild(row.domNode); + row.domNode!.style.height = ''; + this.rowsContainer.appendChild(row.domNode!); renderer.renderElement(item.element, index, row.templateData); - item.size = row.domNode.offsetHeight; + item.size = row.domNode!.offsetHeight; item.renderWidth = this.renderWidth; - this.rowsContainer.removeChild(row.domNode); + this.rowsContainer.removeChild(row.domNode!); this.cache.release(row); return item.size - size; -- GitLab