diff --git a/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts b/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts index afaa9962feabcfb98ad8ab7a545a4ace090dff3e..9b12f126db0ef368f7d1d8d19b73a35c9bb0b97b 100644 --- a/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts +++ b/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts @@ -434,7 +434,7 @@ class PreferencesRenderersController extends Disposable { } } - private async _onEditableContentDidChange(): TPromise { + private async _onEditableContentDidChange(): Promise { await this.localFilterPreferences(this._lastQuery, true); await this.remoteSearchPreferences(this._lastQuery, true); } @@ -511,11 +511,11 @@ class PreferencesRenderersController extends Disposable { return TPromise.join(searchPs).then(() => { }); } - private searchSettingsTarget(query: string, provider: ISearchProvider, target: SettingsTarget, groupId: string, groupLabel: string, groupOrder: number): TPromise { + private searchSettingsTarget(query: string, provider: ISearchProvider, target: SettingsTarget, groupId: string, groupLabel: string, groupOrder: number): Promise { if (!query) { // Don't open the other settings targets when query is empty this._onDidFilterResultsCountChange.fire({ target, count: 0 }); - return TPromise.wrap(null); + return Promise.resolve(null); } return this.getPreferencesEditorModel(target).then(model => { @@ -532,7 +532,7 @@ class PreferencesRenderersController extends Disposable { }); } - private async getPreferencesEditorModel(target: SettingsTarget): TPromise { + private async getPreferencesEditorModel(target: SettingsTarget): Promise { const resource = target === ConfigurationTarget.USER ? this.preferencesService.userSettingsResource : target === ConfigurationTarget.WORKSPACE ? this.preferencesService.workspaceSettingsResource : target; diff --git a/src/vs/workbench/parts/search/browser/searchActions.ts b/src/vs/workbench/parts/search/browser/searchActions.ts index 0fb3e73797658f968450a8e321435dca1b1e3c11..bd2aa0463a99fc6739bc28e1fec717b677045274 100644 --- a/src/vs/workbench/parts/search/browser/searchActions.ts +++ b/src/vs/workbench/parts/search/browser/searchActions.ts @@ -492,14 +492,15 @@ export class ReplaceAllInFolderAction extends AbstractSearchAndReplaceAction { super(Constants.ReplaceAllInFolderActionId, appendKeyBindingLabel(ReplaceAllInFolderAction.LABEL, keyBindingService.lookupKeybinding(Constants.ReplaceAllInFolderActionId), keyBindingService), 'action-replace-all'); } - public async run(): TPromise { + public run(): TPromise { let nextFocusElement = this.getElementToFocusAfterRemoved(this.viewer, this.folderMatch); - await this.folderMatch.replaceAll(); - - if (nextFocusElement) { - this.viewer.setFocus(nextFocusElement); - } - this.viewer.domFocus(); + return this.folderMatch.replaceAll() + .then(() => { + if (nextFocusElement) { + this.viewer.setFocus(nextFocusElement); + } + this.viewer.domFocus(); + }); } }