From 0f3e07c3cd95b4519a5c9fdac0eb397f139a0144 Mon Sep 17 00:00:00 2001
From: Matt Bierner <matb@microsoft.com>
Date: Fri, 26 Oct 2018 14:25:13 -0700
Subject: [PATCH] More explicit types for storage.get with fallbacks

---
 src/vs/base/node/storage.ts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/vs/base/node/storage.ts b/src/vs/base/node/storage.ts
index 1d3b2c578a7..0ed6195434a 100644
--- a/src/vs/base/node/storage.ts
+++ b/src/vs/base/node/storage.ts
@@ -74,6 +74,8 @@ export class Storage extends Disposable {
 		});
 	}
 
+	get(key: string, fallbackValue: string): string;
+	get(key: string, fallbackValue?: string): string | undefined;
 	get(key: string, fallbackValue?: string): string | undefined {
 		const value = this.cache.get(key);
 
@@ -84,6 +86,8 @@ export class Storage extends Disposable {
 		return value;
 	}
 
+	getBoolean(key: string, fallbackValue: boolean): boolean;
+	getBoolean(key: string, fallbackValue?: boolean): boolean | undefined;
 	getBoolean(key: string, fallbackValue?: boolean): boolean | undefined {
 		const value = this.get(key);
 
@@ -94,6 +98,8 @@ export class Storage extends Disposable {
 		return value === 'true';
 	}
 
+	getInteger(key: string, fallbackValue: number): number;
+	getInteger(key: string, fallbackValue?: number): number | undefined;
 	getInteger(key: string, fallbackValue?: number): number | undefined {
 		const value = this.get(key);
 
-- 
GitLab