From 0d809b4036da21038e2c488e95e4920d78bb9248 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Tue, 2 Jul 2019 11:10:13 -0700 Subject: [PATCH] Clean up --- src/vs/vscode.proposed.d.ts | 8 -------- src/vs/workbench/api/browser/mainThreadTerminalService.ts | 7 +------ .../contrib/terminal/browser/terminalProcessManager.ts | 1 - 3 files changed, 1 insertion(+), 15 deletions(-) diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index 52cf3806819..92e842dc78c 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -1283,14 +1283,6 @@ declare module 'vscode' { * extension to act as a terminal's backing process. */ virtualProcess: TerminalVirtualProcess; - - // Allows Windows or non-Windows local link handler to be used based on Live Share host OS - // os?: OperatingSystem; - - // Allows ~ to be resolved in Live Share - // userHome?: string; - - // cwd: string } /** diff --git a/src/vs/workbench/api/browser/mainThreadTerminalService.ts b/src/vs/workbench/api/browser/mainThreadTerminalService.ts index 08b316ba0ba..5ba2b3bbb24 100644 --- a/src/vs/workbench/api/browser/mainThreadTerminalService.ts +++ b/src/vs/workbench/api/browser/mainThreadTerminalService.ts @@ -79,7 +79,6 @@ export class MainThreadTerminalService implements MainThreadTerminalServiceShape } public $createTerminal(name?: string, shellPath?: string, shellArgs?: string[] | string, cwd?: string | UriComponents, env?: { [key: string]: string }, waitOnExit?: boolean, strictEnv?: boolean, hideFromUser?: boolean, isVirtualProcess?: boolean): Promise<{ id: number, name: string }> { - console.log('$createTerminal', arguments); const shellLaunchConfig: IShellLaunchConfig = { name, executable: shellPath, @@ -262,14 +261,10 @@ export class MainThreadTerminalService implements MainThreadTerminalServiceShape } private _onTerminalRequestVirtualProcess(proxy: ITerminalProcessExtHostProxy): void { - console.log('_onTerminalRequestVirtualProcess', proxy); this._terminalProcessesReady[proxy.terminalId](proxy); delete this._terminalProcessesReady[proxy.terminalId]; - proxy.onInput(data => { - console.log('_onTerminalRequestVirtualProcess onInput', data); - this._proxy.$acceptProcessInput(proxy.terminalId, data); - }); + proxy.onInput(data => this._proxy.$acceptProcessInput(proxy.terminalId, data)); proxy.onResize(dimensions => this._proxy.$acceptProcessResize(proxy.terminalId, dimensions.cols, dimensions.rows)); proxy.onShutdown(immediate => this._proxy.$acceptProcessShutdown(proxy.terminalId, immediate)); proxy.onRequestCwd(() => this._proxy.$acceptProcessRequestCwd(proxy.terminalId)); diff --git a/src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts b/src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts index a2fa6621c5d..5bbb0612709 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts @@ -114,7 +114,6 @@ export class TerminalProcessManager implements ITerminalProcessManager { if (shellLaunchConfig.isVirtualProcess) { this._processType = ProcessType.VirtualProcess; this._process = this._instantiationService.createInstance(TerminalProcessExtHostProxy, this._terminalId, shellLaunchConfig, undefined, cols, rows, this._configHelper); - console.log('set terminal process ext host proxy', this._process); } else { const forceExtHostProcess = (this._configHelper.config as any).extHostProcess; if (shellLaunchConfig.cwd && typeof shellLaunchConfig.cwd === 'object') { -- GitLab