Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
0d18a7bb
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
0d18a7bb
编写于
8月 20, 2017
作者:
R
rebornix
提交者:
Peng Lyu
8月 25, 2017
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Avoid memory leak of anonymous decoration types.
上级
23d00f27
变更
1
显示空白变更内容
内联
并排
Showing
1 changed file
with
35 addition
and
13 deletion
+35
-13
src/vs/editor/contrib/colorPicker/browser/colorController.ts
src/vs/editor/contrib/colorPicker/browser/colorController.ts
+35
-13
未找到文件。
src/vs/editor/contrib/colorPicker/browser/colorController.ts
浏览文件 @
0d18a7bb
...
...
@@ -24,12 +24,15 @@ export class ColorController extends Disposable implements IEditorContribution {
}
private
_decorations
:
string
[];
private
_decorationsTypes
:
{
[
key
:
string
]:
boolean
};
constructor
(
private
_editor
:
ICodeEditor
,
@
ICodeEditorService
private
_codeEditorService
:
ICodeEditorService
)
{
super
();
this
.
_decorations
=
[];
this
.
_decorationsTypes
=
{};
this
.
_register
(
_editor
.
onDidChangeModel
((
e
)
=>
this
.
triggerUpdateDecorations
()));
this
.
_register
(
_editor
.
onDidChangeModelContent
((
e
)
=>
this
.
triggerUpdateDecorations
()));
this
.
_register
(
_editor
.
onDidChangeModelLanguage
((
e
)
=>
this
.
triggerUpdateDecorations
()));
...
...
@@ -41,6 +44,7 @@ export class ColorController extends Disposable implements IEditorContribution {
triggerUpdateDecorations
(
settingsChanges
=
false
)
{
getColors
(
this
.
_editor
.
getModel
()).
then
((
colorInfos
)
=>
{
let
decorations
=
[];
let
newDecorationsTypes
:
{
[
key
:
string
]:
boolean
}
=
{};
for
(
let
i
=
0
;
i
<
colorInfos
.
length
&&
decorations
.
length
<
MAX_DECORATORS
;
i
++
)
{
if
(
!
colorInfos
[
i
].
renderDecorator
)
{
...
...
@@ -51,6 +55,8 @@ export class ColorController extends Disposable implements IEditorContribution {
let
subKey
=
hash
(
rgba
).
toString
(
16
);
let
color
=
`rgba(
${
rgba
.
r
}
,
${
rgba
.
g
}
,
${
rgba
.
b
}
,
${
rgba
.
a
}
)`
;
let
key
=
'
colorBox-
'
+
subKey
;
if
(
!
this
.
_decorationsTypes
[
key
]
&&
!
newDecorationsTypes
[
key
])
{
this
.
_codeEditorService
.
registerDecorationType
(
key
,
{
before
:
{
contentText
:
'
'
,
...
...
@@ -66,6 +72,9 @@ export class ColorController extends Disposable implements IEditorContribution {
}
}
});
}
newDecorationsTypes
[
key
]
=
true
;
decorations
.
push
({
range
:
{
startLineNumber
:
colorInfos
[
i
].
range
.
startLineNumber
,
...
...
@@ -77,6 +86,12 @@ export class ColorController extends Disposable implements IEditorContribution {
});
}
for
(
let
subType
in
this
.
_decorationsTypes
)
{
if
(
!
newDecorationsTypes
[
subType
])
{
this
.
_codeEditorService
.
removeDecorationType
(
subType
);
}
}
this
.
_editor
.
changeDecorations
((
changeAccessor
)
=>
{
this
.
_decorations
=
changeAccessor
.
deltaDecorations
(
this
.
_decorations
,
decorations
);
});
...
...
@@ -86,4 +101,11 @@ export class ColorController extends Disposable implements IEditorContribution {
getId
():
string
{
return
ColorController
.
ID
;
}
public
dispose
():
void
{
for
(
let
subType
in
this
.
_decorationsTypes
)
{
this
.
_codeEditorService
.
removeDecorationType
(
subType
);
}
super
.
dispose
();
}
}
\ No newline at end of file
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录