From 0ca70f86cacceca2973561af03164fafe7fc3650 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Mon, 6 Feb 2017 09:55:21 +0100 Subject: [PATCH] tweak perf data --- src/vs/workbench/electron-browser/workbench.main.ts | 2 +- .../performance.contribution.ts | 11 +++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) rename src/vs/workbench/parts/performance/{ => electron-browser}/performance.contribution.ts (81%) diff --git a/src/vs/workbench/electron-browser/workbench.main.ts b/src/vs/workbench/electron-browser/workbench.main.ts index 151ceffc7b0..891f770bbdb 100644 --- a/src/vs/workbench/electron-browser/workbench.main.ts +++ b/src/vs/workbench/electron-browser/workbench.main.ts @@ -104,7 +104,7 @@ import 'vs/workbench/parts/update/electron-browser/update.contribution'; import 'vs/workbench/parts/nps/electron-browser/nps.contribution'; -import 'vs/workbench/parts/performance/performance.contribution'; +import 'vs/workbench/parts/performance/electron-browser/performance.contribution'; import 'vs/workbench/parts/cli/electron-browser/cli.contribution'; diff --git a/src/vs/workbench/parts/performance/performance.contribution.ts b/src/vs/workbench/parts/performance/electron-browser/performance.contribution.ts similarity index 81% rename from src/vs/workbench/parts/performance/performance.contribution.ts rename to src/vs/workbench/parts/performance/electron-browser/performance.contribution.ts index 58917262f52..8b98d26a3e0 100644 --- a/src/vs/workbench/parts/performance/performance.contribution.ts +++ b/src/vs/workbench/parts/performance/electron-browser/performance.contribution.ts @@ -6,6 +6,8 @@ 'use strict'; import { assign } from 'vs/base/common/objects'; +import { join } from 'path'; +import { generateUuid } from 'vs/base/common/uuid'; import { TPromise } from 'vs/base/common/winjs.base'; import { Registry } from 'vs/platform/platform'; import { writeFile } from 'vs/base/node/pfs'; @@ -29,7 +31,7 @@ class PerformanceContribution implements IWorkbenchContribution { if (dumpFile) { // wait for extensions being loaded extensionService.onReady() - .then(() => TPromise.timeout(100)) // time service isn't ready yet because it listens on the same event... + .then(() => TPromise.timeout(1000)) // time service isn't ready yet because it listens on the same event... .then(() => this._dumpTimersAndQuit(dumpFile)) .done(undefined, err => console.error(err)); } @@ -39,11 +41,12 @@ class PerformanceContribution implements IWorkbenchContribution { return 'performance'; } - private _dumpTimersAndQuit(path: string) { + private _dumpTimersAndQuit(folder: string) { const metrics = this._timerService.startupMetrics; - const all = assign({ commit: product.commit }, metrics); + const id = generateUuid(); + const all = assign({ id, commit: product.commit }, metrics); const raw = JSON.stringify(all); - return writeFile(path, raw).then(() => this._windowsService.quit()); + return writeFile(join(folder, `${id}.json`), raw).then(() => this._windowsService.quit()); } } -- GitLab