From 0c5a3da3cf134269c6633d1adcf30af4a0409007 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Sun, 14 Oct 2018 09:52:27 +0200 Subject: [PATCH] sqlite - fix tests --- .../electron-browser/experimentService.test.ts | 18 +++++++++--------- .../experimentalPrompts.test.ts | 2 +- .../extensionsTipsService.test.ts | 6 +++--- .../test/common/gettingStarted.test.ts | 2 +- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/vs/workbench/parts/experiments/test/electron-browser/experimentService.test.ts b/src/vs/workbench/parts/experiments/test/electron-browser/experimentService.test.ts index ec8b8c7e1d3..7a2830d87ed 100644 --- a/src/vs/workbench/parts/experiments/test/electron-browser/experimentService.test.ts +++ b/src/vs/workbench/parts/experiments/test/electron-browser/experimentService.test.ts @@ -76,11 +76,11 @@ suite('Experiment Service', () => { testConfigurationService = new TestConfigurationService(); instantiationService.stub(IConfigurationService, testConfigurationService); instantiationService.stub(ILifecycleService, new TestLifecycleService()); - instantiationService.stub(IStorageService, { get: (a, b, c) => c, getBoolean: (a, b, c) => c, set: () => { } }); + instantiationService.stub(IStorageService, { get: (a, b, c) => c, getBoolean: (a, b, c) => c, store: () => { } }); setup(() => { instantiationService.stub(IEnvironmentService, {}); - instantiationService.stub(IStorageService, { get: (a, b, c) => c, getBoolean: (a, b, c) => c, set: () => { } }); + instantiationService.stub(IStorageService, { get: (a, b, c) => c, getBoolean: (a, b, c) => c, store: () => { } }); }); teardown(() => { @@ -276,7 +276,7 @@ suite('Experiment Service', () => { instantiationService.stub(IStorageService, { get: (a, b, c) => a === 'experiments.experiment1' ? JSON.stringify({ state: ExperimentState.Complete }) : c, - set: (a, b, c) => { } + store: (a, b, c) => { } }); testObject = instantiationService.createInstance(TestExperimentService); @@ -304,7 +304,7 @@ suite('Experiment Service', () => { instantiationService.stub(IStorageService, { get: (a, b, c) => a === 'experiments.experiment1' ? JSON.stringify({ enabled: true, state: ExperimentState.Run }) : c, - set: (a, b, c) => { } + store: (a, b, c) => { } }); testObject = instantiationService.createInstance(TestExperimentService); return testObject.getExperimentById('experiment1').then(result => { @@ -424,7 +424,7 @@ suite('Experiment Service', () => { } return c; }, - set: (a, b, c) => { + store: (a, b, c) => { switch (a) { case 'experiments.experiment1': storageDataExperiment1 = JSON.parse(b); @@ -439,7 +439,7 @@ suite('Experiment Service', () => { break; } }, - delete: a => { + remove: a => { switch (a) { case 'experiments.experiment1': storageDataExperiment1 = null; @@ -500,7 +500,7 @@ suite('Experiment Service', () => { } return c; }, - set: (a, b, c) => { + store: (a, b, c) => { switch (a) { case 'experiments.experiment1': storageDataExperiment1 = JSON.parse(b); @@ -521,7 +521,7 @@ suite('Experiment Service', () => { break; } }, - delete: a => { + remove: a => { switch (a) { case 'experiments.experiment1': storageDataExperiment1 = null; @@ -680,7 +680,7 @@ suite('Experiment Service', () => { } return c; }, - set: (a, b, c) => { + store: (a, b, c) => { switch (a) { case 'experiments.experiment3': storageDataExperiment3 = JSON.parse(b); diff --git a/src/vs/workbench/parts/experiments/test/electron-browser/experimentalPrompts.test.ts b/src/vs/workbench/parts/experiments/test/electron-browser/experimentalPrompts.test.ts index 210113b8633..995f1498e45 100644 --- a/src/vs/workbench/parts/experiments/test/electron-browser/experimentalPrompts.test.ts +++ b/src/vs/workbench/parts/experiments/test/electron-browser/experimentalPrompts.test.ts @@ -64,7 +64,7 @@ suite('Experimental Prompts', () => { storageData = {}; instantiationService.stub(IStorageService, { get: (a, b, c) => a === 'experiments.experiment1' ? JSON.stringify(storageData) : c, - set: (a, b, c) => { + store: (a, b, c) => { if (a === 'experiments.experiment1') { storageData = JSON.parse(b); } diff --git a/src/vs/workbench/parts/extensions/test/electron-browser/extensionsTipsService.test.ts b/src/vs/workbench/parts/extensions/test/electron-browser/extensionsTipsService.test.ts index 2bfd98914c1..c4c8e2d42d1 100644 --- a/src/vs/workbench/parts/extensions/test/electron-browser/extensionsTipsService.test.ts +++ b/src/vs/workbench/parts/extensions/test/electron-browser/extensionsTipsService.test.ts @@ -242,7 +242,7 @@ suite('ExtensionsTipsService Test', () => { instantiationService.stub(INotificationService, new TestNotificationService2()); testConfigurationService.setUserConfiguration(ConfigurationKey, { ignoreRecommendations: false, showRecommendationsOnlyOnDemand: false }); - instantiationService.stub(IStorageService, { get: (a, b, c) => c, getBoolean: (a, b, c) => c, set: () => { } }); + instantiationService.stub(IStorageService, { get: (a, b, c) => c, getBoolean: (a, b, c) => c, store: () => { } }); instantiationService.stub(IModelService, { getModels(): any { return []; }, onModelAdded: onModelAddedEvent.event @@ -453,7 +453,7 @@ suite('ExtensionsTipsService Test', () => { instantiationService.stub(IStorageService, { get: storageGetterStub, - set: () => { }, + store: () => { }, getBoolean: (a, _, c) => a === 'extensionsAssistant/workspaceRecommendationsIgnore' || c }); @@ -491,7 +491,7 @@ suite('ExtensionsTipsService Test', () => { const ignoredExtensionId = 'Some.Extension'; instantiationService.stub(IStorageService, { get: (a, b, c) => a === 'extensionsAssistant/ignored_recommendations' ? '["ms-vscode.vscode"]' : c, - set: (...args) => { + store: (...args) => { storageSetterTarget(...args); } }); diff --git a/src/vs/workbench/parts/welcome/gettingStarted/test/common/gettingStarted.test.ts b/src/vs/workbench/parts/welcome/gettingStarted/test/common/gettingStarted.test.ts index 8a4a9dd3b64..74aabc4cbaf 100644 --- a/src/vs/workbench/parts/welcome/gettingStarted/test/common/gettingStarted.test.ts +++ b/src/vs/workbench/parts/welcome/gettingStarted/test/common/gettingStarted.test.ts @@ -28,7 +28,7 @@ suite('Workbench - GettingStarted', () => { }); instantiation.stub(IStorageService, { get: () => hideWelcomeSettingsValue, - set: (value) => hideWelcomeSettingsValue = value + store: (value) => hideWelcomeSettingsValue = value }); }); -- GitLab