From 084dec8b2988f7200fc27af4a141832c9460badc Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Tue, 26 Feb 2019 11:07:08 +0100 Subject: [PATCH] set the gallery extension only when installation is succeeded --- .../contrib/extensions/node/extensionsWorkbenchService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/extensions/node/extensionsWorkbenchService.ts b/src/vs/workbench/contrib/extensions/node/extensionsWorkbenchService.ts index 644eab55753..67c0c417488 100644 --- a/src/vs/workbench/contrib/extensions/node/extensionsWorkbenchService.ts +++ b/src/vs/workbench/contrib/extensions/node/extensionsWorkbenchService.ts @@ -888,7 +888,6 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService, let extension: Extension | undefined = installingExtension ? installingExtension : zipPath ? new Extension(this.galleryService, this.stateProvider, local, undefined, this.telemetryService, this.logService, this.fileService) : undefined; if (extension) { - extension.gallery = gallery; if (local) { const installed = this.installed.filter(e => areSameExtensions(e.identifier, extension!.identifier))[0]; if (installed) { @@ -897,6 +896,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService, this.installed.push(extension); } extension.local = local; + extension.gallery = gallery; } } this._onChange.fire(error ? undefined : extension); -- GitLab