From 071c6b207789b55da23c54e1c6d9387717e55b14 Mon Sep 17 00:00:00 2001
From: Wang Chi <patr0nus@users.noreply.github.com>
Date: Sat, 1 Sep 2018 02:42:35 +0800
Subject: [PATCH] Check the list length before splicing (#57617)

---
 src/vs/editor/contrib/suggest/suggestWidget.ts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/vs/editor/contrib/suggest/suggestWidget.ts b/src/vs/editor/contrib/suggest/suggestWidget.ts
index 90e7748c573..4c86b7a6a67 100644
--- a/src/vs/editor/contrib/suggest/suggestWidget.ts
+++ b/src/vs/editor/contrib/suggest/suggestWidget.ts
@@ -583,6 +583,10 @@ export class SuggestWidget implements IContentWidget, IVirtualDelegate<ICompleti
 		this.currentSuggestionDetails = createCancelablePromise(token => item.resolve(token));
 
 		this.currentSuggestionDetails.then(() => {
+			if (this.list.length < index) {
+				return;
+			}
+
 			// item can have extra information, so re-render
 			this.ignoreFocusEvents = true;
 			this.list.splice(index, 1, [item]);
-- 
GitLab