From 0705604e0d79c00aa167290f6ac55498baa91b57 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Thu, 17 Aug 2017 14:37:15 +0200 Subject: [PATCH] ignore menu items that have no command, fixes #32673 --- .../platform/actions/electron-browser/menusExtensionPoint.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/platform/actions/electron-browser/menusExtensionPoint.ts b/src/vs/platform/actions/electron-browser/menusExtensionPoint.ts index 401e489ee0f..7801cc6e557 100644 --- a/src/vs/platform/actions/electron-browser/menusExtensionPoint.ts +++ b/src/vs/platform/actions/electron-browser/menusExtensionPoint.ts @@ -329,7 +329,8 @@ ExtensionsRegistry.registerExtensionPoint<{ [loc: string]: schema.IUserFriendlyM let alt = item.alt && MenuRegistry.getCommand(item.alt); if (!command) { - collector.warn(localize('missing.command', "Menu item references a command `{0}` which is not defined in the 'commands' section.", item.command)); + collector.error(localize('missing.command', "Menu item references a command `{0}` which is not defined in the 'commands' section.", item.command)); + continue; } if (item.alt && !alt) { collector.warn(localize('missing.altCommand', "Menu item references an alt-command `{0}` which is not defined in the 'commands' section.", item.alt)); -- GitLab