From 06b9d1850f21c5abcc5c414a9295414fb39d8647 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Wed, 1 Jul 2020 09:07:42 -0700 Subject: [PATCH] Don't call ext link provider for empty lines Fixes #101452 --- .../browser/links/terminalExternalLinkProviderAdapter.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/vs/workbench/contrib/terminal/browser/links/terminalExternalLinkProviderAdapter.ts b/src/vs/workbench/contrib/terminal/browser/links/terminalExternalLinkProviderAdapter.ts index aa8f0f670af..40478f7f7f9 100644 --- a/src/vs/workbench/contrib/terminal/browser/links/terminalExternalLinkProviderAdapter.ts +++ b/src/vs/workbench/contrib/terminal/browser/links/terminalExternalLinkProviderAdapter.ts @@ -47,6 +47,10 @@ export class TerminalExternalLinkProviderAdapter extends TerminalBaseLinkProvide } const lineContent = getXtermLineContent(this._xterm.buffer.active, startLine, endLine, this._xterm.cols); + if (lineContent.trim().length === 0) { + return []; + } + const externalLinks = await this._externalLinkProvider.provideLinks(this._instance, lineContent); if (!externalLinks) { return []; -- GitLab