提交 01a25e94 编写于 作者: B Benjamin Pasero

polish code

上级 817c5c2d
...@@ -22,7 +22,6 @@ import {Registry} from 'vs/platform/platform'; ...@@ -22,7 +22,6 @@ import {Registry} from 'vs/platform/platform';
import Event, {Emitter} from 'vs/base/common/event'; import Event, {Emitter} from 'vs/base/common/event';
import {JSONPath} from 'vs/base/common/json'; import {JSONPath} from 'vs/base/common/json';
// ---- service abstract implementation // ---- service abstract implementation
export interface IStat { export interface IStat {
...@@ -61,7 +60,6 @@ export abstract class ConfigurationService implements IConfigurationService, IDi ...@@ -61,7 +60,6 @@ export abstract class ConfigurationService implements IConfigurationService, IDi
private reloadConfigurationScheduler: RunOnceScheduler; private reloadConfigurationScheduler: RunOnceScheduler;
constructor(contextService: IWorkspaceContextService, eventService: IEventService, workspaceSettingsRootFolder: string = '.vscode') { constructor(contextService: IWorkspaceContextService, eventService: IEventService, workspaceSettingsRootFolder: string = '.vscode') {
this.contextService = contextService; this.contextService = contextService;
this.eventService = eventService; this.eventService = eventService;
...@@ -229,7 +227,7 @@ export abstract class ConfigurationService implements IConfigurationService, IDi ...@@ -229,7 +227,7 @@ export abstract class ConfigurationService implements IConfigurationService, IDi
private handleFileEvents(event: FileChangesEvent): void { private handleFileEvents(event: FileChangesEvent): void {
const events = event.changes; const events = event.changes;
let affectedByChanges = false; let affectedByChanges = false;
for (let i = 0, len = events.length; i < len; i++) { for (let i = 0, len = events.length; i < len; i++) {
const workspacePath = this.contextService.toWorkspaceRelativePath(events[i].resource); const workspacePath = this.contextService.toWorkspaceRelativePath(events[i].resource);
if (!workspacePath) { if (!workspacePath) {
......
...@@ -27,10 +27,12 @@ export class ConfigurationService extends CommonConfigurationService { ...@@ -27,10 +27,12 @@ export class ConfigurationService extends CommonConfigurationService {
public _serviceBrand: any; public _serviceBrand: any;
protected contextService: IWorkspaceContextService;
private toDispose: IDisposable; private toDispose: IDisposable;
constructor(contextService: IWorkspaceContextService, eventService: IEventService) { constructor(
contextService: IWorkspaceContextService,
eventService: IEventService
) {
super(contextService, eventService); super(contextService, eventService);
this.registerListeners(); this.registerListeners();
...@@ -49,7 +51,7 @@ export class ConfigurationService extends CommonConfigurationService { ...@@ -49,7 +51,7 @@ export class ConfigurationService extends CommonConfigurationService {
} }
protected resolveContents(resources: uri[]): TPromise<IContent[]> { protected resolveContents(resources: uri[]): TPromise<IContent[]> {
let contents: IContent[] = []; const contents: IContent[] = [];
return TPromise.join(resources.map((resource) => { return TPromise.join(resources.map((resource) => {
return this.resolveContent(resource).then((content) => { return this.resolveContent(resource).then((content) => {
...@@ -118,12 +120,15 @@ export class ConfigurationService extends CommonConfigurationService { ...@@ -118,12 +120,15 @@ export class ConfigurationService extends CommonConfigurationService {
} }
public setUserConfiguration(key: any, value: any) : Thenable<void> { public setUserConfiguration(key: any, value: any) : Thenable<void> {
let appSettingsPath = this.contextService.getConfiguration().env.appSettingsPath; const appSettingsPath = this.contextService.getConfiguration().env.appSettingsPath;
return readFile(appSettingsPath, 'utf8').then(content => { return readFile(appSettingsPath, 'utf8').then(content => {
let {tabSize, insertSpaces} = this.getConfiguration<{ tabSize: number; insertSpaces: boolean }>('editor'); const {tabSize, insertSpaces} = this.getConfiguration<{ tabSize: number; insertSpaces: boolean }>('editor');
let path: JSONPath = typeof key === 'string' ? (<string> key).split('.') : <JSONPath> key; const path: JSONPath = typeof key === 'string' ? (<string> key).split('.') : <JSONPath> key;
let edits = setProperty(content, path, value, {insertSpaces, tabSize, eol: '\n'}); const edits = setProperty(content, path, value, {insertSpaces, tabSize, eol: '\n'});
content = applyEdits(content, edits); content = applyEdits(content, edits);
return writeFile(appSettingsPath, content, 'utf8'); return writeFile(appSettingsPath, content, 'utf8');
}); });
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册