From 002a1221bb1e2522f7f28e6cef12b30d6c94c1c0 Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Thu, 11 Jul 2019 12:55:23 +0200 Subject: [PATCH] Dispose always --- src/vs/code/node/cliProcessMain.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/vs/code/node/cliProcessMain.ts b/src/vs/code/node/cliProcessMain.ts index 9aeadf8d536..092c1f6be7c 100644 --- a/src/vs/code/node/cliProcessMain.ts +++ b/src/vs/code/node/cliProcessMain.ts @@ -313,7 +313,7 @@ export async function main(argv: ParsedArgs): Promise { const instantiationService: IInstantiationService = new InstantiationService(services); - return instantiationService.invokeFunction(accessor => { + return instantiationService.invokeFunction(async accessor => { const envService = accessor.get(IEnvironmentService); const stateService = accessor.get(IStateService); @@ -350,8 +350,10 @@ export async function main(argv: ParsedArgs): Promise { const instantiationService2 = instantiationService.createChild(services); const main = instantiationService2.createInstance(Main); - return main.run(argv).then(() => { + try { + await main.run(argv); + } finally { disposables.dispose(); - }); + } }); } \ No newline at end of file -- GitLab